Modify to fix issue for #2076, Containment expand problem by xuzhg · Pull Request #2083 · OData/WebApi

xuzhg · 2020-03-12T04:09:12Z

Issues

This pull request fixes issue #2076.

Description

*This fixes the issue in #2076.

For the model builder, all non-containment navigation property should have a navigation property binding.
2)ODataQueryOptionParser should know the "Path" to parse the query option.

Checklist (Uncheck if it is not completed)

Test cases added
Build and test with one-click build and test script passed

Additional work necessary

If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.

See OData#1304

…rate is: AspNet : 4648 pass, 0 fail - 100% enabled, 100% pass AspNetCore: 4123 pass, 97 fail - 91% enabled, 89% pass This change: 1.) ModifiesEnableQuery to return a Json format similar to the HttpError format in AspNet. Many tests are expecting the exact json format from AspNet classic. It's a fine format not specific to any platform so I chose to emulate is for AspNetCore. 2.) Implements async client query pattern as the NetStandard version of the client does not support sync methods. 3.) Modifies LowerCamelCase tests to match error profile of AspNetCore for model validation failures.

…instead of ignoring them.

to avoid having AspNetCore validate the object, which may access properties such as SelectClause which throw if the clause is invalid.

…riPartial.Path) to return the path port of the Uri, which escapes characters that need it. The ODL Parser expects those characters to be escaped. Uri.GetLeftPart(UriPartial.Path) is used in the AspNet version in this scenario as well.

…rate is: AspNet : 4648 pass, 0 fail - 100% enabled, 100% pass AspNetCore: 4155 pass, 65 fail - 91% enabled, 98% pass This change: 1.) Wrap EnableQueryAttribute and IActionFilter in a QueryFilterProvider() in the test fixture. This is similar to the configuration used in the product configuration extensions. 2.) Modifies the case of Json properties in TopSkipOrderByTests.cs. 3.) Implements async client query pattern in SingletonClientTest.cs. 4.) Implements CreateODataPath().

… base path

… version

the description and the QueryFilter itself.

the EntityId. The response code is not set properly until after ExecuteResultAsync() is completed.

key is not present in the SerializableError. Convert the errors in SerializableError into ODataErrorDetail collection.

Fix DollarId test parallel running

* Added support for functions and constants in aggregate expression * Tests for more cannonical functions * Time tests * Support for compute transformation in $apply * Support sorting for columns introduced in compute * Remove redundant code * Fix flakyness in AggregateNavigationPropertyWorks * Fix the ToInt16 overflow during build * Fix typos * Make _values field private * Explicit way to mutate element type and lambda param * Test to demonstrate that we could run compute on complex entity properties * Support for complex types * Simplify keepoing ElementType and LambdaParameter in sync Co-authored-by: Sam Xu <saxu@microsoft.com>

…ata#1986

…ata#1676, PR#1933

… dynamic controller (OData#2035) * Enable endpoint routing using dynamic controller * Update to 7.4.0 * Update the PublicAPI test cases * Add the E2E test cases * Change the startup to test the per-route configuration * Some test codes about policy * Use MatcherPolicy Instead of EndpointSelector to resolve the ambiguity * Address the comments and add LinkGenerator test cases * Revert the EF Core version to 2.2.0 to make Aggregation E2E test pass

mikepizzo · 2021-01-05T19:35:49Z


 namespace AspNetCore3xEndpointSample.Web.Controllers
-{
+{/*


Is there a reason to keep the commented out version?

mikepizzo · 2021-01-05T19:36:25Z


 namespace AspNetCore3xEndpointSample.Web.Models
-{
+{/*


why is this commented out? Is it no longer used? Just remove?

mikepizzo · 2021-01-05T19:37:18Z

+        //public CustomerOrderContext(DbContextOptions<CustomerOrderContext> options)
+        //    : base(options)
+        //{
+        //}


Can this be removed?

mikepizzo · 2021-01-05T19:37:28Z

        public DbSet<Customer> Customers { get; set; }

-        public DbSet<Order> Orders { get; set; }
+     //   public DbSet<Order> Orders { get; set; }


mikepizzo · 2021-01-05T19:37:44Z

-                builder.EntitySet<Order>("Orders");
+                var customers = builder.EntitySet<Customer>("Customers");
+                customers.Binding.HasManyPath(c => c.CustomerReferrals, true).HasRequiredBinding(r => r.ReferredCustomer, "Customers");
+                //     builder.EntitySet<Order>("Orders");


mikepizzo · 2021-01-05T19:40:02Z

-            services.AddDbContext<CustomerOrderContext>(opt => opt.UseLazyLoadingProxies().UseInMemoryDatabase("CustomerOrderList"));
+            //services.AddDbContext<CustomerOrderContext>(opt => opt.UseLazyLoadingProxies().UseInMemoryDatabase("CustomerOrderList"));
+            //services.AddScoped<CustomerOrderContext>(_ => new CustomerOrderContext(Configuration.GetConnectionString("DefaultConnection")));
            services.AddOData();


Remove commented out lines?

mikepizzo · 2021-01-05T20:28:33Z

Is there a test to verify that the issue reported in issue 2076 is addressed? I see changes to the sample but no code that calls them in new ways.

mikepizzo

🕐

mikepizzo · 2021-08-26T19:51:59Z

Hey @xuzhg --

Do you have an update on this PR? I left a few minor comments. Can we address, rebase, and merge, or are there open issues?

xuzhg and others added 30 commits March 20, 2018 10:17

Modify to enable .NET Core test cases in Date and TimeOfDay

c37faa6

Remove the conditional compile for the GetClient

d3ad48c

continue on enabling ASP.NET Core unit tests

e65ba1d

Resolve the comments to use #if NETFX for classic test case

3d0e353

update the ODL reference to 7.4.1

61c0f19

Update the ODL reference to v7.4.1 for all projects

3a34332

update to ODL 7.4.3

bbf8480

fix the classic failing test cases after update to 7.4.3

bafaf00

add the System.Spatial into the classic e2e

417bab3

Fix the enable the Delta with changed property

36af7a6

Update ODataBatchResponseItem.cs

f3b2e28

See OData#1304

This change modifies ETagMessageHandler to operate on ObjectResult's …

2bd6985

…instead of ignoring them.

This change adds the non-validating attribute to ODataQueryOptions.cs

db213d6

to avoid having AspNetCore validate the object, which may access properties such as SelectClause which throw if the clause is invalid.

fix routing issue with batch request, in case web application has any…

d83672e

… base path

Fix the failing test cases, including the public Api

27d1c01

same fix for the failing clasic UT

3953375

Add a sample project for Asp.NET Core OData

4b0a7f6

small changes for the ODataActionSelector & Update the ODL dependency…

92895b9

… version

Fix the failing test case in ApplyTest

480e6c3

Enable public for Unqualified and enum prefix free resolver

43155a5

reset the ODataActionSelector

c3b8486

fix the failing test cases in formattertests.cs

c052d84

update the public api changes in classic

93ddf28

Fix QueryFilterProvider by creating a filter item with both

bc23dcf

the description and the QueryFilter itself.

Fix CreatedODataResult by ensuring the result exists when adding

ce7647a

the EntityId. The response code is not set properly until after ExecuteResultAsync() is completed.

Modify CreateODataError to return a message even if a message

7f1e8ba

key is not present in the SerializableError. Convert the errors in SerializableError into ODataErrorDetail collection.

Make failing test cases in InheritanceTests to work in ASP.NET Core

0c59041

xuzhg and others added 12 commits February 24, 2020 16:29

Fix DollarId test parallel running

6ab92a5

Merge pull request OData#2065 from xuzhg/FixDollarIdParallelTests

81078cb

Fix DollarId test parallel running

Fix MixScenarioTest and Inheritance parallel running problem

ec69a7b

Fix issue#1962: Filtering on a property of casted object fails. PR OD…

8995eae

…ata#1986

Ensures nullable enums are properly handled for In operator. Issue OD…

813349a

…ata#1676, PR#1933

Ensure =compute() works with EFCore3.1, PR OData#2069

c7d6873

Fix OData#1953: Generation of Skiptoken value with DateTime

7f1c284

Fix OData#1947: Use ODataValueProvider, PR OData#1948

c62e8b1

Remove CaseInsensitiveResolver in test, PR OData#1946

dd0d4e2

Enable $batch request with Endpoint routing

e5410e8

xuzhg mentioned this pull request Mar 12, 2020

Embedded $expand not returning the Navigation property in certain scenarios #2076

Open

Modify to fix issue for OData#2076, Containment expand problem

7f03890

xuzhg force-pushed the issue2076ExpandOnNavigation branch from 6667e20 to 7f03890 Compare March 12, 2020 05:28

mikepizzo added this to the 7.5 milestone May 6, 2020

mikepizzo self-requested a review September 8, 2020 23:06

xuzhg removed this from the 7.5 milestone Sep 14, 2020

mikepizzo reviewed Jan 5, 2021

View reviewed changes

mikepizzo suggested changes Jan 5, 2021

View reviewed changes

mikepizzo assigned xuzhg Aug 26, 2021

xuzhg force-pushed the master branch 2 times, most recently from 4c43a84 to ddfd3dd Compare May 29, 2026 01:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modify to fix issue for #2076, Containment expand problem#2083

Modify to fix issue for #2076, Containment expand problem#2083
xuzhg wants to merge 369 commits into
OData:masterfrom
xuzhg:issue2076ExpandOnNavigation

xuzhg commented Mar 12, 2020

Uh oh!

mikepizzo Jan 5, 2021

Uh oh!

mikepizzo Jan 5, 2021 •

edited

Loading

Uh oh!

mikepizzo Jan 5, 2021

Uh oh!

mikepizzo Jan 5, 2021

Uh oh!

mikepizzo Jan 5, 2021

Uh oh!

mikepizzo Jan 5, 2021

Uh oh!

mikepizzo commented Jan 5, 2021

Uh oh!

mikepizzo left a comment

Uh oh!

mikepizzo commented Aug 26, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Conversation

xuzhg commented Mar 12, 2020

Issues

Description

Checklist (Uncheck if it is not completed)

Additional work necessary

Uh oh!

mikepizzo Jan 5, 2021

Choose a reason for hiding this comment

Uh oh!

mikepizzo Jan 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mikepizzo Jan 5, 2021

Choose a reason for hiding this comment

Uh oh!

mikepizzo Jan 5, 2021

Choose a reason for hiding this comment

Uh oh!

mikepizzo Jan 5, 2021

Choose a reason for hiding this comment

Uh oh!

mikepizzo Jan 5, 2021

Choose a reason for hiding this comment

Uh oh!

mikepizzo commented Jan 5, 2021

Uh oh!

mikepizzo left a comment

Choose a reason for hiding this comment

Uh oh!

mikepizzo commented Aug 26, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

mikepizzo Jan 5, 2021 •

edited

Loading