[16.0] queue_job: backports from 18.0 #874
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @guewen, |
This allows creating test job with a long duration for stress testing.
When a SerializationFailure occurs when updating the state of dependent jobs, the cursor is not usable anymore so the retry failed with `current transaction is aborted`. A savepoint fixes that.
In this commit we cleanly separate the job acquisition (i.e. verifying the job is in the exepected state, marking it started and locking it) from job execution. We also avoid trying to start the job if it is already locked by using SKIP LOCKED and exiting early. Indeed in such situations the job is likely already being handled by another worker so there is no point trying to start it, so we exit early and let it be handled either by the other worker or the dead job requeuer.
Extract the logic to run one job out of the /queue_job/runjob route. Towards making this logic reusable in other job executors.
Towards making this logic reusable.
Since we are not going to delete records nor modify foreign keys, we can take a weaker lock.
thomaspaulb
force-pushed
the
16.0-queue_job-backports
branch
from
b4dada5 to
227a5e7
Compare
…rts patches Otherwise monkey-patches could be added twice when instantiating new test classes.
thomaspaulb
changed the title
sbidoul
approved these changes
Jan 21, 2026
Member
|
@thomaspaulb I did not review each line. Can you confirm the cherry picks did apply cleanly, or did you have to fiddle and there are things that need additional eyes? |
Contributor
Author
|
I think in the end they all cherry-picked cleanly, when they did not, I just went looking for some prerequisite ones that i missed before. But there may have been one case of fiddling. If you want to know for sure I could go and repeat the cherrypicking to doublecheck. Also, today this went into production so some feedback may come of that. If both these "checks" come out OK i guess we can merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports of:
enqueue_waiting#867These are basically blind cherry-picks, so let's first see how the unit tests run and how this behaves in production