Repository navigation
[19.0] [FIX] website_sale_hide_no_variant_attributes: never block add to cart - #1347
Open
ivantodorovich wants to merge 1 commit into
Open
ivantodorovich wants to merge 1 commit into
ivantodorovich wants to merge 1 commit into
Conversation
ivantodorovich
force-pushed
the
19.0-imp-website_sale_hide_no_variant_attributes-add-to-cart
branch
from
October 7, 2026 17:48
e47864e to
a3f42f4
Compare
… add to cart Attributes that never create variants are hidden from the product page, but their values were still required to sell the product. When those values are excluded for some variants, no complete combination may be left, and the product cannot be sold at all. Steps to reproduce: 1. Create a product with a Size attribute (Small, Large) that creates variants. 2. Add a Material attribute that never creates variants, with the single value Cotton, and set its "Exclude for" to Large. 3. Add a Finish attribute that never creates variants, with the single value Glossy, and set its "Exclude for" to Small. 4. Open the product page. The page says "This product has no valid combination" and has no Add to Cart button, although both sizes exist and can be sold.
ivantodorovich
force-pushed
the
19.0-imp-website_sale_hide_no_variant_attributes-add-to-cart
branch
from
October 7, 2026 18:26
a3f42f4 to
80a5e40
Compare
ivantodorovich
marked this pull request as ready for review
October 7, 2026 18:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attributes that never create variants are hidden from the product page, but their values were still required to sell the product. When those values are excluded for some variants, no complete combination may be left, and the product cannot be sold at all.
When no complete combination exists, the product now falls back on the variant-defining values alone: for the Add to Cart check, and for the first combination used by the product page, the shop grid, the wishlist, the comparison pages and the backend configurator.
Steps to reproduce
Current: "This product has no valid combination", no Add to Cart button.
Expected: both sizes can be selected and added to the cart.