Skip to content

Docs for subscriptions#1201

Merged
alejcas merged 4 commits intoO365:masterfrom
RogerSelwyn:subscription-docs
Jan 20, 2026
Merged

Docs for subscriptions#1201
alejcas merged 4 commits intoO365:masterfrom
RogerSelwyn:subscription-docs

Conversation

@RogerSelwyn
Copy link
Contributor

To add documentation in support of subscriptions

@RogerSelwyn
Copy link
Contributor Author

I've significantly changed the content and then referenced the example app in the examples directory. I've also removed some of the validation of numbers from the example code, since that removes focus from the core code that makes it work.

Reality is this could actually be cut more to remove all but the webhook url, since that is the only one that is actually needed to make the subscriptions work. Everything else can be initiated in code if needed. I'm open to thoughts on this.

@RogerSelwyn
Copy link
Contributor Author

Marking ready for review and comment. I'll take any suggestions.

@RogerSelwyn RogerSelwyn marked this pull request as ready for review December 31, 2025 12:30
@alejcas
Copy link
Member

alejcas commented Jan 20, 2026

Why adding flask a dev requirement?

@RogerSelwyn
Copy link
Contributor Author

I think I added it to support testing subscriptions. I believe it can be removed.

@alejcas alejcas merged commit 12e177b into O365:master Jan 20, 2026
@alejcas
Copy link
Member

alejcas commented Jan 20, 2026

Thanks @RogerSelwyn, merged!

@RogerSelwyn RogerSelwyn deleted the subscription-docs branch January 21, 2026 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants