Merged
Conversation
Contributor
Author
|
I've significantly changed the content and then referenced the example app in the examples directory. I've also removed some of the validation of numbers from the example code, since that removes focus from the core code that makes it work. Reality is this could actually be cut more to remove all but the webhook url, since that is the only one that is actually needed to make the subscriptions work. Everything else can be initiated in code if needed. I'm open to thoughts on this. |
Contributor
Author
|
Marking ready for review and comment. I'll take any suggestions. |
Member
|
Why adding flask a dev requirement? |
Contributor
Author
|
I think I added it to support testing subscriptions. I believe it can be removed. |
Member
|
Thanks @RogerSelwyn, merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To add documentation in support of subscriptions