Warn when creating packages with non-ASCII characters in the package ID#14950
Open
nkolev92 wants to merge 4 commits into
Open
Warn when creating packages with non-ASCII characters in the package ID#14950nkolev92 wants to merge 4 commits into
nkolev92 wants to merge 4 commits into
Conversation
jeffkl
previously approved these changes
Jun 16, 2026
jeffkl
left a comment
jeffkl
left a comment
Contributor
There was a problem hiding this comment.
Probably also worth mentioning that other feed implementations will probably enforce the new naming conventions, but we aren't 100%.
Also make sure to call out that if/when its ever changed to an error, we'll always need an escape hatch for Pack so users can't create packages that use invalid characters just in case.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design for #14949
Related: NuGet/Announcements#75