[train][multimodal][1/3] Add vision support to generate() in new inference stack#1494
Merged
SumanthRH merged 2 commits intoNovaSky-AI:mainfrom Apr 13, 2026
Merged
Conversation
2 tasks
SumanthRH
approved these changes
Apr 13, 2026
Member
What is SKYRL_LOCAL_VLLM @nithinvc? Tests should pass with vllm 0.19.0 |
Contributor
Author
|
A temporary flag till vllm-project/vllm#38405 gets merged in. It's been approved but the auto-merger hasn't merged it in (there's some test timeout unrelated to my changes). The tests will likely only pass with vllm 0.20.0 when this is in |
Member
|
Ok sounds good. let's get this in anyways |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1/3 PRs for for #1493 - multi-turn VLM generator
Adds multimodal generation support to the inference client, enabling
RemoteInferenceClient.generate()to forward multi-modal features (image hashes, placeholder ranges, kwargs) from vLLM's render endpoint through to the generation endpoint.mm_featuresthroughRemoteInferenceClient.generate()and_generate_single(), conditionally attaching them as"features"in the HTTP payload to the vLLM servermm_processor_cache_gb=0to vLLM CLI args to disable the multimodal processor cache. Required otherwise vLLM won't return multi-modal features for repeated image rendering (/renderis not idempotent).test_generate_with_multimodal_features_red_square) that exercises the full render -> generate round-trip with a VLMTest plan
test_remote_inference_client.pytests pass:uv run pytest tests/backends/skyrl_train/inference_servers/test_remote_inference_client.py -vTestMultiModalGenerationtest passes: verifies mm_features reach the server payloadSKYRL_LOCAL_VLLM=1 uv run --isolated --extra dev --extra fsdp pytest tests/backends/skyrl_train/gpu/gpu_ci/inference_servers/test_vlm_inference_generation.py -m vllm -v