fix: color execution time based on duration in verbose mode (#680)#681
Merged
fraxken merged 2 commits intoNodeSecure:masterfrom Mar 23, 2026
Merged
Conversation
In verbose mode, execution time was always displayed in cyan (blue). Now uses a color palette to help spot slow operations: - ≤1s: green (fast) - 1-5s: cyan (normal) - 5-30s: yellow (slow) - ≥30s: red (very slow) Fixes NodeSecure#680 Signed-off-by: zlplzp123wyt <zlplzp123wyt@users.noreply.github.com>
fraxken
approved these changes
Mar 22, 2026
PierreDemailly
approved these changes
Mar 22, 2026
Member
|
ESLint is failing in CI, please fix |
Contributor
Author
|
Fixed the lint error (added missing blank line before return statement). CI should be passing now. Ready for merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In verbose mode, execution time was always displayed in cyan (blue). This PR introduces a color palette to make it easier to spot slow operations.
Fixes #680
Problem
When running in verbose mode, all execution times are displayed in the same cyan color regardless of how long they take, making it hard to quickly identify slow operations.
Solution
Added a
colorExecutionTime()helper function that returns the formatted time string with a color based on the duration:Changes
src/commands/scanner.js: AddedcolorExecutionTime()function and applied it to the verbose stat output