Open
Conversation
IDCs
reviewed
Apr 16, 2026
| "styles:compile": (filePaths: string[]) => Promise<string>; | ||
|
|
||
| // Download channels | ||
| "download:start": ( |
Contributor
There was a problem hiding this comment.
Not a biggie, but the naming of this channel got me thinking for a second - primarily about the fact that we're just sending off the destination as a parameter (without actually specifying what we're downloading); had to look at the code to understand that this is basically a per design enqueue to this path rather than a start downloading this file to dest.
So for example if I were to use this channel via a community extension, I'd be wondering why it's asking me just for a destination.
IDCs
approved these changes
Apr 16, 2026
Contributor
IDCs
left a comment
IDCs
left a comment
There was a problem hiding this comment.
Overall pretty happy with this, but as I mentioned previously - the download:start channel naming is somewhat misleading as a contributor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes APP-227.