Merged
Conversation
Update version string, CITATION.cff date, citation year to 2026, add Hajhassani to author lists, and add v1.6 dev section in whats_new.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fc946ce4ef
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Export GuttmannFlury2025_ME from datasets __init__.py - Remove non-existent dataset references (Guger2009, McCann2015, LeBlanc2024_A/B) from whats_new.rst - Add pandas to intersphinx mapping in conf.py - Add version guard in conf.py to detect installed vs source mismatch - Fix cross-reference types across base classes: Pipeline -> sklearn.pipeline.Pipeline, ndarray -> numpy.ndarray, DataFrame -> pandas.DataFrame, Figure -> matplotlib.figure.Figure - Fix inherited docstrings in BaseDataset, BaseProcessing, and BaseEvaluation that propagated warnings to 150+ subclasses - Fix numpydoc formatting (Parameters: -> Parameters, missing blank lines before lists, unreferenced citations) - Add internal base classes (MNEBNCI, ErpCore2021, Mainsah2025, etc.) to api.rst so Sphinx can resolve class hierarchy references - Add minimal nitpick_ignore for genuinely unfixable numpydoc artifacts (default values, shape descriptors, sentence fragments parsed as types)
…t rejection tutorial Switch pyriemann dependency from GitHub source (master) to PyPI (>=0.7) for the 1.5.0 release. Rename the Riemannian Artifact Rejection tutorial to remove the plot_ prefix so sphinx-gallery skips auto-execution, since it requires PotatoField features only available from source. Add a warning block to the tutorial documenting this requirement.
- Remove all nitpick_ignore and nitpick_ignore_regex from conf.py - Fix broken cross-references in whats_new.rst: typos (moabb.evaluation -> moabb.evaluations), wrong roles (:func: for classes), internal modules changed to plain text backticks - Fix numpydoc type annotations across evaluations, paradigms, pipelines, and analysis modules: move default values from type fields to description text, replace shape specs in type fields with description text, use proper Sphinx cross-references for numpy/pandas/sklearn/mne types - Fix prepare_summary_tables.py to generate correct cross-reference paths for internal base classes (ErpCore2021)
- Add private base classes (_Dreyer2023Base, _base_bi_il, _BaseVisualMatrixSpellerDataset, CompoundDataset) to api.rst so autodoc class hierarchy references resolve - Update sklearn/mne intersphinx URLs to https - Add minimal nitpick_ignore_regex for sklearn-generated docstrings (set_params, get_params, set_*_request metadata routing) that use numpydoc conventions unresolvable by Sphinx - Fix numpydoc formatting in BaseDataset, CompoundDataset, P300, set_download_dir, fs_get_file_list, kumar2024, and plotting docstrings that leaked description text into type fields
…al in 1.1 Remove all @depreciated_alias decorators and their old-name imports (bi2012, bi2013a, bi2014a, bi2014b, bi2015a, bi2015b, VirtualReality, MunichMI, HeadMountedDisplay, SSVEPExo, and compound bi_illiteracy aliases). Add old names to _REMOVED_DATASETS for clear error messages. Guard zip(*aliases_list) calls against the now-empty list. Also add missing GuttmannFlury2025_ME entry to summary_imagery.csv.
…ove tracked docs/source/README.md Restore Chevallier, S. as last author. Add Begany, K. to README.md and cite.rst citations (previously only in CITATION.cff). Remove docs/source/README.md from tracking since it is auto-generated by the docs Makefile copy-readme target.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
moabb/__init__.pyandCITATION.cffcite.rst,README.md, anddocs/source/README.mdwhats_new.rstand mark v1.5 as stable (PyPi)Test plan
python -c "import moabb; print(moabb.__version__)"→1.5.01.4.3references in modified files1.5.0present in all 5 target filesHajhassanipresent in all 4 citation files