Skip to content

Refactor intents and tests to simplify resources#22

Draft
NeonDaniel wants to merge 8 commits intodevfrom
FEAT_RefactorEntityHandling
Draft

Refactor intents and tests to simplify resources#22
NeonDaniel wants to merge 8 commits intodevfrom
FEAT_RefactorEntityHandling

Conversation

@NeonDaniel
Copy link
Copy Markdown
Member

Description

Update intent files to use llm entity
Update intent tests

Issues

Other Notes

@NeonDaniel NeonDaniel marked this pull request as draft April 25, 2024 18:50
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean we need to not use things like 'jack chi pt' or long long lists of choices? I'm not clear if I need to change some things.

Copy link
Copy Markdown
Member

@NeonClary NeonClary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you set up "llm" to hold all the terms so we wouldn't have to keep typing and changing them everywhere? I was wanting to do that but didn't know how yet. :-)

I don't fully follow everything, please merge however works out easiest for you, I can go make my changes in the new correct location afterwards if needed, no big deal.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants