PR for upcoming 5.2.0 release (Is now ready for release)#111
Open
Athar42 wants to merge 12 commits intoNavoei:mainfrom
Open
PR for upcoming 5.2.0 release (Is now ready for release)#111Athar42 wants to merge 12 commits intoNavoei:mainfrom
Athar42 wants to merge 12 commits intoNavoei:mainfrom
Conversation
- Add default mob heads/skulls to the allowed list to be played - Update Gradle Shadow to release 9.3.1
- Fix : Mining head/skull to keep its custom data. - Fix : Breaking noteblock and/or head (by hand or explosion) stop any playing audio. - Fix : Triggering a noteblock restart the head custom audio. - Will not be fixed (for now) : An explosion will drop the head but will wiped any custom data. You'll have to recreate it with /cd create...
- Reorder checks for HopperManager + use of local variable to avoid excessive external calls (shouldn't change a lot "performance wise", but still a little better this way)
- Update Discord invite link
- Correct Readme
Full changelog (including Beta) : - Add default mob heads/skulls to the allowed list to be played - Fix : Mining head/skull to keep its custom data. - Fix : An explosion will drop the head and keep any custom data. - Fix : Breaking noteblock and/or head (by hand or explosion) stop any playing audio. - Fix : Triggering a noteblock restart the head custom audio. - Reorder checks for HopperManager + use of local variable to avoid excessive external calls (shouldn't change a lot "performance wise", but still a little better this way) - Fix Jukebox and PlayerHead playing behavior when they are subject to explosions either in Nether (bed, respawn anchor, ...) or Overworld. - Added an "Update checker" option, enabled by default. This will prompt a notify notice in case of an available plugin update (if OP or the corresponding permission is set : "customdiscs.update"). - Making downloads from Filebin.net possible ! - Switch from ProtocolLib to PacketEvents - Update Discord invite link - Update the Readme.md file - Update Gradle Shadow to release 9.3.2
Failed with the video link at the end on Github
Failed with the video link at the end on Github
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The numbers got messed up 😅