Conversation
Vulnerable Libraries (2)
More info on how to fix Vulnerable Libraries in JavaScript. 👉 Go to the dashboard for detailed results. 📥 Happy? Share your feedback with us. |
|
I really appreciate your effort. But since it is a big change, I can create a separate branch to merge the changes to so I can test them locally first. Can you please remove change to yarn.lock, any generated bundle file, or package file. If you really need them, you can mention the changes to PR and I'll do that. |
|
I've created a new branch 'v6' for this change |
|
Hi @amitguptagwl, I've updated my branch with the latest changes from v6 and redirected the target of the pr to the v6 branch. |
|
Hi @amitguptagwl, thank you for tidying up this PR and removing those files. Are there any further changes you would like to see to help keep this moving along? |
|
I really appreciate your effort. But I'm holding the changes to be merged due to some changes in the library. I'll update you. This would be on priority as soon as the v6 comes on priority. |
|
That makes sense. Just let me know when you're ready for this to be picked up again. Thanks again for your efforts maintaining this library. |
I wanted to get this library working in ESM for V6. Apologies for large PR - I needed to get the v6 library working for me asap.
package.jsonforfast-xml-parser/v6, enabling direct ESM and type-safe imports for v6 classes and types.docs/v6/1.GettingStarted.md,docs/v6/3.Options.md,docs/v6/4.OutputBuilders.md) to provide usage examples for new types and ESM importsV6ParserOptionsandV6BuilderOptionsBug Fixes:
Xml2JsParserwhere trailing whitespace could cause a false positive for unexpected data at the end of the document. (Related issue but this fix is only in v6 Newlines at the end of file are throwing exception in v5 xmlParser #704 )New Features:
Type
Note : Please ensure that you've read contribution guidelines before raising this PR. If your PR is in progress, please prepend
[WIP]in PR title. Your PR will be reviewed when[WIP]will be removed from the PR title.