Skip to content

Add support for nested meta-data inside android manifest components#5

Merged
simonhamp merged 2 commits into
NativePHP:mainfrom
Mallon94:main
May 11, 2026
Merged

Add support for nested meta-data inside android manifest components#5
simonhamp merged 2 commits into
NativePHP:mainfrom
Mallon94:main

Conversation

@Mallon94

@Mallon94 Mallon94 commented Feb 1, 2026

Copy link
Copy Markdown
Contributor

Problem

  • Some android services need additional meta-data within the service level of the manifest.

Solution

  • Added buildComponentMetaData function to place in nested metadata. Can be used in future for other components in the manifest if they need nested meta-data.

@simonhamp simonhamp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test to cover this

…ding value and resource attributes, boolean values, kebab-case keys, and intent filters.
@Mallon94 Mallon94 requested a review from simonhamp February 25, 2026 20:32

@shanerbaner82 shanerbaner82 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All 232 tests pass after merging main. Clean implementation with good test coverage.

@rmiller335 rmiller335 mentioned this pull request Apr 9, 2026
@simonhamp simonhamp merged commit bc52c81 into NativePHP:main May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants