Change supported center concept to NAC center - #1215
Merged
kevinherdez merged 3 commits intoAug 4, 2026
Conversation
yuliadub
reviewed
Jul 24, 2026
| } else { | ||
| // Supported centers are sorted according to their order in supportedAvalancheCenters | ||
| return centers.findIndex(supported => supported.center === a.center.id) - centers.findIndex(supported => supported.center === b.center.id); | ||
| // NAC centers are sorted according to their order in supportedAvalancheCenters |
Collaborator
There was a problem hiding this comment.
need to update to new function name or remove comment 🙂
yuliadub
reviewed
Jul 24, 2026
yuliadub
reviewed
Jul 24, 2026
yuliadub
approved these changes
Jul 24, 2026
Collaborator
|
excited for the future when we will have only one lists of center names to update, thanks for getting us started on that path 😀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the Map Project, there's no longer going to be a distinction between known centers and supported (paying) centers. Since all centers are going to be shown on the map, the distinction is now between NAC centers that we can fully support in the app and non NAC centers (infox, UAC, CAIC, and AvCan) that we currently can't fetch forecasts, obs, and weather data for.
Main Changes
isSupportedCenterconcept has been refactored toisNACCenteralong with the other relevant functionsAvalancheCentersenum as it's not needed anymoreNeed help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.