Bug fix for VS 2026 / msvc 195 / MSVC Build Tools 14.51#60
Draft
garethsb wants to merge 3 commits into
Draft
Conversation
Signed-off-by: Gareth Sylvester-Bradley <garethsb@nvidia.com>
conan-canary Windows jobs use MSVC 195 and build nmos-cpp from source; Conan Center cmake/<4 cannot generate for Visual Studio 18 2026. Override tool_requires to cmake/[>=4.2.0 <5] in conan-canary only. See conan-io/conan-center-index#28884. Signed-off-by: Gareth Sylvester-Bradley <garethsb@nvidia.com>
garethsb
force-pushed
the
bugfix/garethsb-msvc-195
branch
from
f1e389b to
e558259
Compare
Only build-nmos-cpp-from-source keeps MSVC 195 and the cmake 4.2 override. Signed-off-by: Gareth Sylvester-Bradley <garethsb@nvidia.com>
garethsb
force-pushed
the
bugfix/garethsb-msvc-195
branch
from
33ccf71 to
a9c4875
Compare
Collaborator
Author
|
After both sony/nmos-cpp PRs have been merged, the MSVC 195 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After sony/nmos-cpp#497 fixed detection to not pick
<experimental/filesystem>there are a few more problems to resolve.First, no "Visual Studio 18 2026" generator in CMake 3.31. It may get backported but for now we need CMake >=4.2.
See conan-io/conan-center-index#28884.
Next, cpprestsdk uses
std::ios_base::_Openprotwhich has been removed by microsoft/STL@e2ef398. Possible fix submitted as sony/nmos-cpp#498.