Fix kernel URL references for kernel_read and kernel client#19
Open
fallintoplace wants to merge 1 commit into
Open
Fix kernel URL references for kernel_read and kernel client#19fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
Collaborator
|
Thank you! Nice fix — one small thing before merge. Versioned URLs like normalized_kernel_ref = kernel_ref(args.kernel_ref)
if "scriptVersionId=" in args.kernel_ref:
print(
"Note: scriptVersionId is ignored — kernel_read always fetches the latest "
"version. Use kernel_archive.py to fetch a specific historical version."
)Everything else LGTM — tests pass locally against latest main. 👍 |
0dbe3c8 to
645576c
Compare
Signed-off-by: Minh Vu <vuhoangminh97@gmail.com>
645576c to
0f759b8
Compare
Contributor
Author
|
Thank you for the review, I have pushed the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The kernel documentation accepts Kaggle code URLs, but the kernel_read CLI and KaggleKernelClient previously expected owner/slug references. A full URL could therefore be parsed as the wrong owner and slug.
What changed
Validation