[release-1.19] feat(nvcdi): Allow IPC sockets to not be discovered.#1808
Merged
cdesiniotis merged 1 commit intorelease-1.19from May 7, 2026
Merged
[release-1.19] feat(nvcdi): Allow IPC sockets to not be discovered.#1808cdesiniotis merged 1 commit intorelease-1.19from
cdesiniotis merged 1 commit intorelease-1.19from
Conversation
There are cases we are dealing with where the containers should not have access to any NVIDIA IPC sockets like fabricmanager/persistenced. We want the ability to disable this. This commit adds a feature flag `disable-ipc-discoverer` that if provided will cause the IPC discoverer.Discoverer to be nil. Ultimately, this is needed so that the CDI spec file generated by k8s-device-plugin does not include these sockets. Signed-off-by: LandonTClipp <lclipp@coreweave.com> (cherry picked from commit 6dad053)
Contributor
|
/ok to test e1a3e95 |
cdesiniotis
approved these changes
May 7, 2026
Coverage Report for CI Build 25518459206Coverage increased (+0.005%) to 43.325%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Automated backport of #1790 to
release-1.19✅ Cherry-pick completed successfully with no conflicts.
Original PR: #1790
Original Author: @LandonTClipp
Cherry-picked commits (1):
6dad053feat(nvcdi): Allow IPC sockets to not be discovered.This backport was automatically created by the backport bot.