build(deps): bump protobuf 29.1 -> 30.0 to fix NixOS build#105
Merged
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
janickm
force-pushed
the
bump-protobuf-30
branch
4 times, most recently
from
525f333 to
6ab5993
Compare
Replace the archived rules_proto module (7.1.0) with a direct bazel_dep on protobuf 30.0, and bump TensorFlow from 2.16 to 2.20: - Remove rules_proto; load proto_library from @protobuf//bazel directly (Waymo dataset patch updated accordingly) - Bump TF to >= 2.20, which requires protobuf >= 5.x — this eliminates the version conflict between pip protobuf (previously 4.25.6) and the Bazel protobuf module's Python runtime, removing the sys.path hack in tools/data_converter/waymo/deps.py - Pin pip protobuf to 6.30.x to match Bazel protobuf 30.0, ensuring the protoc compiler and Python runtime are from the same release Testing: - bazel build //... passes - bazel test --config=no-gpu //... passes (28/28 tests) - Waymo dataset conversion verified end-to-end (198 frames)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
single_version_overridein MODULE.bazelWhy
Protobuf 29.x uses
ctx.actions.run_shellwithsed/cpinembed_edition_defaults, which fails on NixOS where those tools live in/nix/storeand are not at/usr/bin. Protobuf 30.0 rewrites this toctx.actions.runwith proper argument passing (#19409), eliminating the shell dependency entirely.rules_protois archived at 7.1.0 (pinned to protobuf 29.1), sosingle_version_overrideis the correct way to bump.Testing
bazel build //...— passesbazel test --config=no-gpu //...— 25/28 pass (3 failures are pre-existing Py3.8 + PyTorchlibtorch_cpu.soissue, unrelated)TODO before merging