Skip to content

Restored default nvml api #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dschervov wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Restored default nvml api #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions pkg/nvml/device.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3276,21 +3276,23 @@ func (device nvmlDevice) GetCoolerInfo() (CoolerInfo, Return) {
// nvml.DeviceGetTemperatureV()
type TemperatureHandler struct {
device nvmlDevice
sensorType TemperatureSensors
}

func (handler TemperatureHandler) V1() (Temperature, Return) {
var temperature Temperature
temperature.Version = STRUCT_VERSION(temperature, 1)
temperature.SensorType = uint32(handler.sensorType)
ret := nvmlDeviceGetTemperatureV(handler.device, &temperature)
return temperature, ret
}

func (l *library) DeviceGetTemperatureV(device Device) TemperatureHandler {
return device.GetTemperatureV()
func (l *library) DeviceGetTemperatureV(device Device, sensorType TemperatureSensors) TemperatureHandler {
return device.GetTemperatureV(sensorType)
}

func (device nvmlDevice) GetTemperatureV() TemperatureHandler {
return TemperatureHandler{device}
func (device nvmlDevice) GetTemperatureV(sensorType TemperatureSensors) TemperatureHandler {
return TemperatureHandler{device, sensorType}
}

// nvml.DeviceGetMarginTemperature()
Expand Down
8 changes: 4 additions & 4 deletions pkg/nvml/mock/device.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions pkg/nvml/mock/interface.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pkg/nvml/zz_generated.api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,7 +588,7 @@ type Interface interface {
DeviceGetTargetFanSpeed(Device, int) (int, Return)
DeviceGetTemperature(Device, TemperatureSensors) (uint32, Return)
DeviceGetTemperatureThreshold(Device, TemperatureThresholds) (uint32, Return)
DeviceGetTemperatureV(Device) TemperatureHandler
DeviceGetTemperatureV(Device, TemperatureSensors) TemperatureHandler
DeviceGetThermalSettings(Device, uint32) (GpuThermalSettings, Return)
DeviceGetTopologyCommonAncestor(Device, Device) (GpuTopologyLevel, Return)
DeviceGetTopologyNearestGpus(Device, GpuTopologyLevel) ([]Device, Return)
Expand Down Expand Up @@ -959,7 +959,7 @@ type Device interface {
GetTargetFanSpeed(int) (int, Return)
GetTemperature(TemperatureSensors) (uint32, Return)
GetTemperatureThreshold(TemperatureThresholds) (uint32, Return)
GetTemperatureV() TemperatureHandler
GetTemperatureV(TemperatureSensors) TemperatureHandler
GetThermalSettings(uint32) (GpuThermalSettings, Return)
GetTopologyCommonAncestor(Device) (GpuTopologyLevel, Return)
GetTopologyNearestGpus(GpuTopologyLevel) ([]Device, Return)
Expand Down