Binary search optimization for Parquet Variant's object field ID lookup - #23638
Open
abigalekim wants to merge 4 commits into
Open
Binary search optimization for Parquet Variant's object field ID lookup#23638abigalekim wants to merge 4 commits into
abigalekim wants to merge 4 commits into
Conversation
abigalekim
marked this pull request as draft
August 12, 2026 19:29
abigalekim
marked this pull request as ready for review
August 12, 2026 20:21
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe change adds sortedness-aware object field lookup for Parquet variant extraction. Sorted field IDs use binary search. Unsorted field IDs use linear scanning. Path resolution reads sortedness metadata and passes it to the lookup. ChangesVariant object path resolution
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
Author
|
/ok to test 3d840b7 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
locate_object_fieldmaps an integer dictionary ID to the encoded bytes of a field value within a Parquet Variant object blob. This function previously did a linear scan over all field IDs to find the matching entry. This PR implements binary search forlocate_object_fieldwhen the Variant metadata's sorted_strings bit is set, which guarantees that field IDs within an object are sorted.Checklist