fix(test-plan): update legacy control-plane IDs

[abegnoche]

Summary

• Replace remaining legacy control-plane test IDs with stable catalog IDs in Nico wiring and coverage tests.
• Update the control-plane suite comment to reference the stable access-key lifecycle IDs.

Test plan

• Pre-commit hooks passed during commit, including test-plan coverage and suite checks.

Summary by CodeRabbit

• Documentation
  • Clarified control-plane teardown notes for access-key lifecycle checks.
  • Standardized validation/test references to use consistent control-plane identifiers.
• Tests
  • Updated coverage checks to match the revised validation identifiers, keeping existing behavior unchanged.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5984c082-72b3-4c62-82cf-993f87e3661c

📥 Commits

Reviewing files that changed from the base of the PR and between ef3e600 and 1a35864.

📒 Files selected for processing (3)

• isvctl/configs/providers/nico/config/control-plane.yaml
• isvctl/configs/suites/control-plane.yaml
• scripts/tests/test_test_plan_coverage.py

---

📝 Walkthrough

Walkthrough

The PR replaces placeholder control-plane test IDs with specific CP references in provider config, test coverage input, and suite teardown guidance. The access-key teardown comment now names the create and disable checks explicitly.

Changes

Control-plane test ID renumbering

Layer / File(s)	Summary
Canonical ID values isvctl/configs/providers/nico/config/control-plane.yaml, scripts/tests/test_test_plan_coverage.py	The provider FieldValueCheck and the coverage test input now use CP03-01 and CP07-01 instead of placeholder IDs.
Teardown comment update isvctl/configs/suites/control-plane.yaml	The delete_access_key teardown comment now references CP05-01 and CP06-01 for the access-key create/disable flow.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

• NVIDIA/ai-cloud-validation#480: Broad control-plane test ID renumbering and suite wiring changes overlap with the same CP identifier updates.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the PR’s main change: replacing legacy control-plane IDs with stable catalog IDs.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

🔐 TruffleHog Secret Scan

✅ No secrets or credentials found!

Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉

🔗 View scan details

_{🕐 Last updated: 2026-06-26 18:36:39 UTC | Commit: 1a35864}