-
Notifications
You must be signed in to change notification settings - Fork 631
Add NVTE_KEEP_BACKWARD_UNQUANTIZED #2644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zianglih
wants to merge
40
commits into
NVIDIA:main
Choose a base branch
from
zianglih:keep-bwd
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
3afce1f
Add NVTE_KEEP_BACKWARD_UNQUANTIZED
zianglih 72149be
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 3e6eb64
Merge branch 'main' into keep-bwd
zianglih 927d482
Disable ub and clean up
zianglih cc85b60
Drop fuser changes
zianglih fe24f95
Replace use_quantized_bwd with use_fp8_bwd
zianglih 5ca3615
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 5ba7674
Ignore keep_backward_unquantized if delayed scaling
zianglih 02b7b2a
Refactor ignoring NVTE_KEEP_BACKWARD_UNQUANTIZED when delayed scaling…
zianglih 01a7de0
Add back missing ctx.debug
zianglih bf904aa
Refactor changes under fused
zianglih b449fc4
Clean up
zianglih de3acaf
Refactor high-precision overwrite if keep_backward_unquantized
zianglih fe65d34
Clean up
zianglih 59aaf6b
Drop redundant fp8_recipe_bwd
zianglih 44da625
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 0f58793
Drop redundant ub changes
zianglih 192fbad
Drop more redundant ub changes
zianglih 0dd1268
Drop redundant delayed scaling changes
zianglih 216621d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] ab8749b
Drop unneeded backwards_needs_fc1_input
zianglih 5881083
Drop and disallow LayerNormMLP implementation
zianglih 431f0c8
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 937e34b
Move interface changes to recipe
zianglih 0d26127
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 0135366
Move ub overrides to fwd
zianglih 1de3c64
Remove duplication
zianglih 04d3543
Simplify use_fp8_bwd logic in bwd
zianglih 454976e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] f7794c9
Set grad quantizers to none if keep bwd unquantized
zianglih 58db8ea
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 9d0b654
Drop delayed scaling change
zianglih 004cb45
Simplify env var logic
zianglih 9baccfd
Move validation check to recipe
zianglih 207eb5a
Simplify effective_enabled
zianglih 15117b1
Fix inverted assertion logic
zianglih 3fc5270
Simplify changes under ops
zianglih 9201d19
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 1e0f1d2
Simplify ctx.keep_backward_unquantized
zianglih 253873a
Fix missing attribute
zianglih File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assertion prevents using
NVTE_KEEP_BACKWARD_UNQUANTIZED=1withDelayedScalingrecipe - when env var is set,quantize_backwardbecomesFalse, making this assert fail and blocking the entire feature for this recipe type