fix(server): share gateway shutdown channel#1945
Merged
Merged
Conversation
Signed-off-by: Evan Lezar <elezar@nvidia.com>
SDAChess
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the
mainCI Rust lint failure from https://github.com/NVIDIA/OpenShell/actions/runs/27656754843/job/81792472668 by removing the duplicate gateway shutdown channel introduced by the merge of #1870 onto amainthat already included #1577.PR #1870 passed checks on stale head
29d57cc, which did not include #1577. The final merge commitff028ce0combined #1870 TLS reload shutdown handling with #1577 compute watcher shutdown handling, shadowingshutdown_txand leaving the first sender unused under-D warnings.Related Issue
None.
Changes
run_servershutdown channel for compute watchers, TLS reload, and gateway listener shutdown.watch::channel(false)allocation that shadowedshutdown_txandshutdown_rx.Testing
mise run rust:lintpassesmise run pre-commitpassesmise run pre-commitwas attempted locally and failed in the unrelatedhelm:linttask before this PR changes any Helm files:chart metadata is missing these dependencies: postgresql. Rust lint, rust check, and Rust tests completed successfully during that run before the overall task exited non-zero.Checklist