test(e2e): retry forward proxy stale policy flake#1929
Merged
Conversation
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
|
Label |
TaylorMutch
approved these changes
Jun 16, 2026
elezar
reviewed
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retry expected-allowed forward-proxy e2e requests across the startup policy symlink-resolution reload. This addresses the main-branch Release Dev flake where an in-flight forward request can see a stale policy generation and transiently return
403.Related Issue
Refs #1810
Changes
Testing
mise run pre-commitpassesrustfmt --edition 2024 --check e2e/rust/tests/forward_proxy_graphql_l7.rs e2e/rust/tests/forward_proxy_l7_bypass.rscargo test --manifest-path e2e/rust/Cargo.toml --features e2e-docker --test forward_proxy_l7_bypass --no-runcargo test --manifest-path e2e/rust/Cargo.toml --features e2e-docker --test forward_proxy_graphql_l7 --no-rungit diff --check -- e2e/rust/tests/forward_proxy_graphql_l7.rs e2e/rust/tests/forward_proxy_l7_bypass.rsmise run pre-commitwas attempted locally but did not complete in this temporary worktree. It failedpython:protowhile the newly-created venv was missinggrpc_tools; the Rust lint phase also hit local toolchain/dependency failures (z3.hmissing forz3-sys, plus anaws-lc-sysGCC/macOS SDK compile error). The focused e2e targets compile.Checklist