fix(e2e): refresh latest sandbox image for docker runs#1928
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
Label |
f9899bb to
a3bc5bf
Compare
This fixes an issue where you may run e.g. `mise run e2e:python`, then after Python is upgraded in mise.toml, subsequent runs of `e2e:python` fail because the Python version is out of sync. Signed-off-by: Kris Hicks <khicks@nvidia.com>
a3bc5bf to
50ad503
Compare
Signed-off-by: Evan Lezar <elezar@nvidia.com>
50ad503 to
2b875e0
Compare
|
@krishicks I split my follow-up into a separate commit on top of your original change so the history shows the intent clearly. The reason for the follow-up is that The follow-up keeps the good part of the change: the wrapper refreshes the configured default |
Summary
This fixes an issue where you may run e.g.
mise run e2e:python, then after Python is upgraded in mise.toml, subsequent runs ofe2e:pythonfail because the Python version is out of sync.Agent notes:
Details
I changed the Docker e2e wrapper so:
I chose pull-on-latest over pinning because this path already depends on the community base:latest image tracking the repo toolchain. Pinning a digest would just move the sync burden into the repo every time Python changes.
Related Issue
Changes
latestor no tag (which is treated aslatest)Testing
mise run pre-commitpassesChecklist