Skip to content

docs(rfc): require issues before RFCs#1918

Merged
drew merged 9 commits into
mainfrom
rfc-guidance-updates
Jun 16, 2026
Merged

docs(rfc): require issues before RFCs#1918
drew merged 9 commits into
mainfrom
rfc-guidance-updates

Conversation

@drew

@drew drew commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

Update RFC guidance so users open GitHub issues before RFCs, maintainers request RFCs only when necessary, and maintainers assign RFC numbers from the originating issue. Also correct stale RFC status metadata for existing RFCs.

Related Issue

None.

Changes

  • Require new features to start from the feature request template rather than RFC PRs.
  • Document maintainer-controlled RFC number assignment from issues.
  • Align the RFC template, contributor guidance, architecture overview, and feature request template.
  • Correct existing RFC front matter statuses: RFC 0000 to accepted, RFC 0001 and RFC 0002 to accepted, RFC 0003 to implemented.

Testing

  • mise run pre-commit passes
    • Attempted, but local toolchain/dependency setup failed before completing: python:proto could not find grpc_tools on its first concurrent run, rust:lint could not build z3-sys because z3.h was missing, and aws-lc-sys failed while Homebrew GCC compiled against a macOS SDK header that uses block syntax.
  • git diff --check passes
  • mise run markdown:lint:md passes
  • Unit tests added/updated (not applicable; docs/template-only)
  • E2E tests added/updated (not applicable; docs/template-only)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)

Signed-off-by: Drew Newberry <anewberry@nvidia.com>
@drew drew requested review from a team, derekwaynecarr and mrunalp as code owners June 15, 2026 23:18
drew added 2 commits June 15, 2026 16:22
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
TaylorMutch
TaylorMutch previously approved these changes Jun 15, 2026
Comment thread rfc/README.md Outdated
pimlock
pimlock previously approved these changes Jun 15, 2026
Comment thread rfc/README.md Outdated
Comment thread rfc/README.md
Co-authored-by: krishicks <khicks@nvidia.com>
@drew drew dismissed stale reviews from pimlock and TaylorMutch via b2ca320 June 16, 2026 14:55
drew added 2 commits June 16, 2026 07:59
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
@drew drew requested a review from maxamillion as a code owner June 16, 2026 23:12
drew added 3 commits June 16, 2026 16:28
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
@drew drew merged commit 5ca39b0 into main Jun 16, 2026
27 checks passed
@drew drew deleted the rfc-guidance-updates branch June 16, 2026 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants