Skip to content

refactor(vm): remove legacy openshell-vm crate#1239

Merged
drew merged 1 commit into
mainfrom
remove-openshell-vm-crate
May 7, 2026
Merged

refactor(vm): remove legacy openshell-vm crate#1239
drew merged 1 commit into
mainfrom
remove-openshell-vm-crate

Conversation

@drew
Copy link
Copy Markdown
Collaborator

@drew drew commented May 7, 2026

Summary

Remove the excluded legacy openshell-vm crate now that openshell-driver-vm is the supported VM path.

Related Issue

N/A

Changes

  • Removed crates/openshell-vm and its standalone runtime scripts/tests.
  • Removed the workspace exclude entry and the unused openshell_vm_base_dir helper.
  • Updated architecture, RFC, AGENTS, and VM driver docs to point only at openshell-driver-vm.
  • Removed stale k3s setup pins/comments from VM runtime infrastructure.
  • Removed explicit VM rootfs cleanup/tests for legacy k3s, kubectl, Rancher, chart, and manifest artifacts.

Testing

  • cargo metadata --no-deps --format-version 1
  • cargo check --workspace
  • cargo test -p openshell-driver-vm
  • mise run pre-commit passes
  • mise run test
  • E2E tests added/updated (if applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

@drew drew requested review from a team, derekwaynecarr, maxamillion and mrunalp as code owners May 7, 2026 17:06
@drew drew force-pushed the remove-openshell-vm-crate branch 2 times, most recently from 739e801 to 985a90e Compare May 7, 2026 17:18
TaylorMutch
TaylorMutch previously approved these changes May 7, 2026
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
@drew drew force-pushed the remove-openshell-vm-crate branch from 985a90e to a0a7164 Compare May 7, 2026 17:28
@drew drew merged commit 028763d into main May 7, 2026
22 checks passed
@drew drew deleted the remove-openshell-vm-crate branch May 7, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants