Skip to content

fix(packaging): let gateway auto-detect package driver #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drew merged 1 commit into from
May 7, 2026
Merged

fix(packaging): let gateway auto-detect package driver #1236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions crates/openshell-driver-vm/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,13 +182,17 @@ The VM guest's serial console is appended to `<state-dir>/<sandbox-id>/console.l

On Linux amd64 and arm64, `install-dev.sh` installs the Debian package from the
selected `OPENSHELL_VERSION` release tag. That package includes
`openshell-gateway` and `openshell-driver-vm`.
`openshell-gateway` and `openshell-driver-vm`, but leaves
`OPENSHELL_DRIVERS` unset so the gateway uses its normal runtime
auto-detection. Set `OPENSHELL_DRIVERS=vm` to force the VM driver.

On Apple Silicon macOS, `install-dev.sh` stages the generated `openshell.rb`
formula from the selected release in the `nvidia/openshell` Homebrew tap.
Homebrew installs `openshell`, `openshell-gateway`, and
`openshell-driver-vm`, ad-hoc signs the driver with the Hypervisor entitlement
in `post_install`, and owns the `brew services` gateway lifecycle.
in `post_install`, and owns the `brew services` gateway lifecycle. The service
also leaves `OPENSHELL_DRIVERS` unset so driver choice remains automatic unless
the user explicitly overrides it.

## Relationship to `openshell-vm`

Expand Down
1 change: 0 additions & 1 deletion deploy/deb/openshell-gateway.service
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ Environment=OPENSHELL_SERVER_PORT=17670
Environment=OPENSHELL_DISABLE_TLS=true
Environment=OPENSHELL_DISABLE_GATEWAY_AUTH=true
Environment=OPENSHELL_DB_URL=sqlite:%S/openshell/gateway/openshell.db
Environment=OPENSHELL_DRIVERS=vm
Environment=OPENSHELL_GRPC_ENDPOINT=http://127.0.0.1:17670
Environment=OPENSHELL_SSH_GATEWAY_HOST=127.0.0.1
Environment=OPENSHELL_SSH_GATEWAY_PORT=17670
Expand Down
3 changes: 2 additions & 1 deletion python/openshell/release_formula_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from pathlib import Path


def test_generate_homebrew_formula_uses_tagged_macos_driver_asset(
def test_generate_homebrew_formula_uses_tagged_macos_driver_asset_without_default_driver(
tmp_path: Path,
) -> None:
release_dir = tmp_path / "release"
Expand Down Expand Up @@ -51,6 +51,7 @@ def test_generate_homebrew_formula_uses_tagged_macos_driver_asset(
"v0.0.10/openshell-driver-vm-aarch64-apple-darwin.tar.gz"
) in formula
assert 'sha256 "' + "b" * 64 + '"' in formula
assert "OPENSHELL_DRIVERS" not in formula
assert 'OPENSHELL_DRIVER_DIR: "#{opt_libexec}"' in formula
assert "entitlements.atomic_write" in formula
assert "brew services restart openshell" in formula
1 change: 0 additions & 1 deletion tasks/scripts/release.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,6 @@ def post_install
OPENSHELL_DISABLE_TLS: "true",
OPENSHELL_DISABLE_GATEWAY_AUTH: "true",
OPENSHELL_DB_URL: "sqlite:#{{var}}/openshell/gateway/openshell.db",
OPENSHELL_DRIVERS: "vm",
OPENSHELL_GRPC_ENDPOINT: "http://127.0.0.1:{LOCAL_GATEWAY_PORT}",
OPENSHELL_SSH_GATEWAY_HOST: "127.0.0.1",
OPENSHELL_SSH_GATEWAY_PORT: "{LOCAL_GATEWAY_PORT}",
Expand Down
Loading