feat(plugin): load rust_dynamic plugins in relay#307
Draft
willkill07 wants to merge 2 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
2 tasks
95aee26 to
a2eb759
Compare
a2eb759 to
096d576
Compare
096d576 to
186668d
Compare
186668d to
0c89f8f
Compare
0c89f8f to
0171643
Compare
0171643 to
e118a8b
Compare
e118a8b to
54be92c
Compare
Signed-off-by: Will Killian <wkillian@nvidia.com>
54be92c to
d5f5b7c
Compare
Signed-off-by: Will Killian <wkillian@nvidia.com>
d5f5b7c to
2af45a9
Compare
License DiffCompared against Lockfile license changesLockfile License ChangesRustAdded
Removed
Updated/Changed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add the host-side
rust_dynamicnative plugin loader and gateway activation path.Stack dependency: this PR cannot be merged until parent stacked PR #306 is merged: #306
Details
Validation run across the completed stack:
cargo test -p nemo-relay-typescargo test -p nemo-relay-plugincargo test -p nemo-relay-worker-protocargo test -p nemo-relay-workercargo check -p nemo-relay-cliWhere should the reviewer start?
Start with
crates/core/src/plugin/dynamic/native.rs, then review the activation wiring incrates/cli/src/server.rs.Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)