Open
Conversation
To improve readability
For easier readability
yhtang
reviewed
Apr 22, 2024
| @@ -6,34 +6,33 @@ on: | |||
| T5X_IMAGE: | |||
| type: string | |||
| description: T5X image from ghcr.io/nvidia/t5x | |||
| default: 'ghcr.io/nvidia/t5x:latest' | |||
Contributor
There was a problem hiding this comment.
To my understanding, single quotes are preferred in GitHub Actions as they are less likely to cause unintended effects (not 100% sure how much practical impact it will bring though). Besides, it is better to be consistent across code base 😄
Contributor
Author
There was a problem hiding this comment.
Good point! I changed my formatter's default to single-quotes
ko3n1g
force-pushed
the
ko3n1g/ci/restore-rosetta-t5x-test
branch
from
1d15a60 to
80ccc49
Compare
Contributor
|
Hitting this GHA limitation agaaaaaaain 🤣 |
Contributor
Author
Lol, that's really wild. Seems we found the reason why it was left like that? How important is this test? What do you think about converting some workflows to actions? I'm looking at those workflows which consist of a single job only. These are the pros/cons I can see:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We noticed together that
.github/workflows/_test_rosetta.yamlwasn't used anymore. Suggestion by @terrykong was to consolidate it together with.github/workflows/_test_rosetta_t5x.yaml