Conversation
ko3n1g
force-pushed
the
ko3n1g/rosetta-maxtext
branch
from
5c53064 to
7f3cfac
Compare
ko3n1g
force-pushed
the
ko3n1g/rosetta-maxtext
branch
from
75be08e to
9514f68
Compare
| latest_verified_commit: 78daad198544def8274dbd656d122fbe6a0e1129 | ||
| mode: git-clone | ||
| patches: | ||
| mirror/patch/test_rosetta_maxtext: file://patches/maxtext/mirror-patch-rosetta-maxtext.patch |
There was a problem hiding this comment.
Just leaving a reminder that this can be cleaned up if not needed
There was a problem hiding this comment.
I could not see the patch file in the repo. Are we using it?
| @@ -1,41 +1,150 @@ | |||
| name: "~Sandbox" | |||
|
|
|||
| name: Sandbox | |||
There was a problem hiding this comment.
Just a reminder to revert before merging
| @@ -0,0 +1 @@ | |||
| local/ | |||
There was a problem hiding this comment.
Is this a debug line? Does it need to be committed?
There was a problem hiding this comment.
We can remove it. I found it convenient to have local testing directory which isn't checked into git.
terrykong
left a comment
terrykong
left a comment
There was a problem hiding this comment.
Thanks for the contribution! I left a few comments
ko3n1g
force-pushed
the
ko3n1g/rosetta-maxtext
branch
from
c548314 to
6fee7c1
Compare
Co-authored-by: Terry Kong <terryk@nvidia.com>
ko3n1g
force-pushed
the
ko3n1g/rosetta-maxtext
branch
2 times, most recently
from
fce07fc to
8e452da
Compare
ko3n1g
force-pushed
the
ko3n1g/rosetta-maxtext
branch
2 times, most recently
from
a132242 to
0669659
Compare
To comply with naming convention
ko3n1g
force-pushed
the
ko3n1g/rosetta-maxtext
branch
2 times, most recently
from
99db46d to
24ce939
Compare
|
I noticed the front-page readme doesn't have all the badges/rows we expect for maxtext: |
ko3n1g
force-pushed
the
ko3n1g/rosetta-maxtext
branch
from
8ddf125 to
5ea2a1c
Compare
ko3n1g
force-pushed
the
ko3n1g/rosetta-maxtext
branch
from
5ea2a1c to
0fa40ad
Compare
ko3n1g
force-pushed
the
ko3n1g/rosetta-maxtext
branch
from
29541c9 to
a4564f7
Compare
kocchop
left a comment
kocchop
left a comment
There was a problem hiding this comment.
Left a few comments, please take a look
There was a problem hiding this comment.
Why are we again building TE here? The base image should be jax-mealkit:jax, right? And then we apply patch and build the final
There was a problem hiding this comment.
we did not run the tests for rosetta-maxtext yet, right? we should check the validity of the rosetta build
3 participants
This PR adds a maxtext rosetta build. To be consistent with other rosetta builds, I renamed
maxtexttoupstream-maxtext.🚨 It contains a test commit which must be removed before merging. 🚨