Rename msg time references to hdr time

[bmchalenv]

Replace all "message time" / "msg" identifiers that refer to header-based timestamps with "header time" / "hdr" equivalents across code, tests, Python utilities, and documentation. Updates struct fields, function names, diagnostic key strings, local variables, and comments consistently.

[greptile-apps]

Greptile Summary

This PR performs a comprehensive renaming refactoring to replace "message time" / "msg" terminology with "header time" / "hdr" terminology across code, tests, and documentation. The changes clarify that these timestamps come from message headers rather than general message metadata.

Key Changes:

• Renamed struct fields, function parameters, and member variables from msg_time to hdr_time variants
• Updated diagnostic key strings (e.g., frame_rate_msg → frame_rate_hdr)
• Renamed test functions and local variables for consistency
• Updated documentation to reflect the new terminology

Minor Issues:

• Some Python variables (msg_str, msg_val) and fields (msg_rate) retain "msg" naming despite holding header-based values
• These are non-functional style inconsistencies that could be addressed for complete consistency

Confidence Score: 4/5

• This PR is safe to merge with minimal risk - it's a pure renaming refactoring with no logic changes
• The refactoring is thorough and consistent across C++ code, tests, and documentation. All diagnostic keys, struct fields, function names, and parameters have been systematically renamed. Tests have been updated to match the new naming. The only concerns are minor style inconsistencies in Python variable/field names that don't affect functionality.
• Pay attention to greenwave_monitor/greenwave_monitor/test_utils.py and greenwave_monitor/greenwave_monitor/ui_adaptor.py for potential follow-up naming consistency improvements

Important Files Changed

Filename	Overview
greenwave_monitor/greenwave_monitor/test_utils.py	Updated diagnostic key references; minor naming inconsistencies in local variables msg_str and msg_val
greenwave_monitor/greenwave_monitor/ui_adaptor.py	Updated diagnostic key from frame_rate_msg to frame_rate_hdr; field name msg_rate not updated for consistency
greenwave_monitor/include/greenwave_diagnostics.hpp	Comprehensive renaming of all msg time references to hdr time across struct fields, member variables, function parameters, and diagnostic keys - thorough and consistent

_{Last reviewed commit: e412892}

[greptile-apps]

_{8 files reviewed, 3 comments}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

Additional Comments (3)

greenwave_monitor/greenwave_monitor/test_utils.py
Variable name msg_str is inconsistent with the renaming. Since it now holds the value from frame_rate_hdr, consider renaming to hdr_str.

        hdr_str = None
        latency_str = None

        for kv in status.values:
            if kv.key == 'frame_rate_node':
                node_str = kv.value
            elif kv.key == 'frame_rate_hdr':
                hdr_str = kv.value

---

greenwave_monitor/greenwave_monitor/test_utils.py
Variable name msg_val is inconsistent with the renaming. Consider renaming to hdr_val to match the new frame_rate_hdr terminology (also update all references on lines 207, 212, 213, 218).

---

greenwave_monitor/greenwave_monitor/ui_adaptor.py
Field name msg_rate is inconsistent with the renaming. Since it holds the value from frame_rate_hdr, consider renaming to hdr_rate to maintain consistency with the header time terminology.

_{Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!}

[sgillen]

Let's wait on this one until we're ready to use greenwave in NITROS, else the frontend no longer works with NITROS diagnostics.