Conversation
theangchen
reviewed
May 29, 2025
Collaborator
theangchen
left a comment
There was a problem hiding this comment.
Typo under Explaination for TimePicker:
defaultValue={formDatastartTime}
should be:
defaultValue={formData.startTime}
theangchen
approved these changes
May 29, 2025
Collaborator
theangchen
left a comment
There was a problem hiding this comment.
@jaygiang This looks good. I was able to step through Lesson 2 ✅
- Just need fix the 1 typo
- Make sure the imports we're supposed to add in this lesson are removed in StartTrip.jsx
- Double check the line numbers are correct for the FormGroup in StartTrip.jsx. It was close but slightly off for me.
Otherwise good to go.
docs/learn/lesson-2.mdx
Outdated
| * `minTime`, `maxTime`, and `step={15}` configure the available time options (from 00:00 to 23:30 in 15-minute increments). | ||
| * `validationStatus` and `className` are used for conditional error styling, similar to the `DatePicker`. | ||
| - Similar to the `DatePicker`, we use `FormGroup` and `Label` for structure and accessibility | ||
| - `defaultValue={formDatastartTime}` binds the input to the `startTime` field in our state |
Collaborator
There was a problem hiding this comment.
Typo here. Should be:
defaultValue={formData.startTime}
Collaborator
Author
|
Thanks @theangchen! I made the typo update. Also, I'll write those notes down for when I update the learn-radfish startTrip.jsx file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves the structure, clarity, and completeness of the "Lesson 2: Start Trip Form Inputs" tutorial documentation.
Structure and Formatting
###for subsections)1.1,1.2,2.1,2.2, etc.)//diff-add-startand//diff-add-endtagsContent Enhancements
TimePicker,Select)TimePickerexample with corrected properties:maxTimefrom"23:30"to"23:45"requiredMarkerproperty instead of manual<span>elementsTechnical Accuracy
onChangehandler for clarity