-
Notifications
You must be signed in to change notification settings - Fork 3
NIAD-3416: Performance improvements #1235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Images built and published to ECR using a Build Id of PR-925-fd807bc |
|
|
Can we improve the description / why / what of this PR please. The
The
|
...-translator/src/test/java/uk/nhs/adaptors/pss/translator/util/ResourceReferenceUtilTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file still has places where we have assertions such as: assertThat(references.size()).isOne() which is less efficient than assertThat(references).hasSize(1)
What
Caching unmarshaller in XmlUnmarshallUtil class
Why
Creating unmarshallers is a very expensive operation and it takes (unnecessarily) a lot of resources. Once we create an unmarshaller it should be cached and reused for better efficiency.
Type of change
Please delete options that are not relevant.
Checklist: