Skip to content

Conversation

@MartinWheelerMT
Copy link
Collaborator

@MartinWheelerMT MartinWheelerMT commented Jan 8, 2026

What

  • Replace all references to request and references to types created for request with equivalent axios packages.
  • Refactor api.ts to use axios, adjusting the handling of requests and responses accordingly.
  • Remove now obsolete types from index.ts.
  • Update package.json and auto-generate package-lock.json to reflect the package changes.

Why

Request npm package was marked as obsolete a good number of years ago, and is no longer maintained (see request/request#3142). This package represents a critical security risk due to multiple transitive dependencies it introduces, such as form-data:

image

This needs to be replaced with a maintained package, in this case axios, to ensure critical vulnerabilities are not exposed.

Type of change

Please delete options that are not relevant.

  • Internal change (non-breaking change with no effect on the functionality affecting end users)

Checklist:

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation where required
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the Changelog with details of my change in the UNRELEASED section if this change affects end users.

* Replace all references to `request` and references to types created for request with equivalent `axios` packages.
* Refactor `api.ts` to use axios, adjusting the handling of requests and responses accordingly.
* Remove now obsolete types from `index.ts`.
* Update `package.json` and auto-generate `package-lock.json` to reflect the package changes.
@MartinWheelerMT MartinWheelerMT requested a review from a team as a code owner January 8, 2026 15:39
@MartinWheelerMT MartinWheelerMT enabled auto-merge (squash) January 8, 2026 15:42
@github-actions
Copy link

github-actions bot commented Jan 8, 2026

Images built and published to ECR using a Build Id of PR-268-1cf07e4

Copy link

@Jonopono123 Jonopono123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MartinWheelerMT MartinWheelerMT merged commit 009ed9a into main Jan 8, 2026
8 checks passed
@MartinWheelerMT MartinWheelerMT deleted the replace-obsolete-request-package branch January 8, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants