Skip to content

[PRM-710] SonarQube Cloud and redlines compliance #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrisbloe merged 38 commits into from
Mar 10, 2026

More package upgrades

55f68e7
Select commit
Loading
Failed to load commit list.
Merged

[PRM-710] SonarQube Cloud and redlines compliance #89

More package upgrades
55f68e7
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 10, 2026 in 36s

Quality Gate failed

Failed conditions
23 Security Hotspots
41.9% Coverage on New Code (required ≥ 80%)
C Security Rating on New Code (required ≥ A)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 69 in lambdas/splunk_cloud_event_uploader/test_splunk_cloud_event_uploader_main.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this parameter "mock_PoolManager" to match the regular expression ^[_a-z][a-z0-9_]*$. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_gp2gp-enhanced-mi-infrastructure&issues=AZzSZ0uvz78EidrS186S&open=AZzSZ0uvz78EidrS186S&pullRequest=89

Check failure on line 52 in tasks_github_actions.sh

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_gp2gp-enhanced-mi-infrastructure&issues=AZzXJgc5wIIOqDQ9Wplm&open=AZzXJgc5wIIOqDQ9Wplm&pullRequest=89

Check warning on line 20 in lambdas/error_alarm_alert/error_alarm_alert_main.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Initialize this AWS client outside the Lambda handler function. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_gp2gp-enhanced-mi-infrastructure&issues=AZzSZ0sFz78EidrS186L&open=AZzSZ0sFz78EidrS186L&pullRequest=89

Check warning on line 86 in tasks_github_actions.sh

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of using the literal 'lambdas' 5 times. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_gp2gp-enhanced-mi-infrastructure&issues=AZzXJgc5wIIOqDQ9Wplh&open=AZzXJgc5wIIOqDQ9Wplh&pullRequest=89

Check warning on line 19 in lambdas/splunk_cloud_event_uploader/test_splunk_cloud_event_uploader_main.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this parameter "mock_PoolManager" to match the regular expression ^[_a-z][a-z0-9_]*$. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_gp2gp-enhanced-mi-infrastructure&issues=AZzSZ0uvz78EidrS186R&open=AZzSZ0uvz78EidrS186R&pullRequest=89

Check failure on line 668 in lambdas/event_enrichment/test_event_enrichment_main.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Change this argument; Function "get_supplier_name_from_sds_api" expects a different type 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_gp2gp-enhanced-mi-infrastructure&issues=AZzTadqhkZa_-9vKPWcQ&open=AZzTadqhkZa_-9vKPWcQ&pullRequest=89

Check warning on line 7 in tasks_github_actions.sh

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add an explicit return statement at the end of the function. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_gp2gp-enhanced-mi-infrastructure&issues=AZzXJgc5wIIOqDQ9Wplo&open=AZzXJgc5wIIOqDQ9Wplo&pullRequest=89

Check warning on line 122 in lambdas/bulk_ods_update/bulk_ods_update.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable "odsCode" to match the regular expression ^[_a-z][a-z0-9_]*$. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_gp2gp-enhanced-mi-infrastructure&issues=AZzSZ0u4z78EidrS186V&open=AZzSZ0u4z78EidrS186V&pullRequest=89

Check warning on line 21 in lambdas/degrades_reporting/degrade_utils/utils.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable "eventType" to match the regular expression ^[_a-z][a-z0-9_]*$. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_gp2gp-enhanced-mi-infrastructure&issues=AZzSZ0rfz78EidrS1856&open=AZzSZ0rfz78EidrS1856&pullRequest=89

Check failure on line 20 in tasks_github_actions.sh

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_gp2gp-enhanced-mi-infrastructure&issues=AZzXJgc5wIIOqDQ9Wpli&open=AZzXJgc5wIIOqDQ9Wpli&pullRequest=89

Check failure on line 33 in tasks_github_actions.sh

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_gp2gp-enhanced-mi-infrastructure&issues=AZzXJgc5wIIOqDQ9Wpll&open=AZzXJgc5wIIOqDQ9Wpll&pullRequest=89

Check warning on line 43 in lambdas/degrades_reporting/degrade_utils/s3_service.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add logic to this except clause or eliminate it and rethrow the exception automatically. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_gp2gp-enhanced-mi-infrastructure&issues=AZzSZ0rmz78EidrS1859&open=AZzSZ0rmz78EidrS1859&pullRequest=89

Check warning on line 419 in lambdas/event_enrichment/test_event_enrichment_main.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this parameter "mock_PoolManager" to match the regular expression ^[_a-z][a-z0-9_]*$. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_gp2gp-enhanced-mi-infrastructure&issues=AZzSZ0tvz78EidrS186P&open=AZzSZ0tvz78EidrS186P&pullRequest=89

Check warning on line 395 in lambdas/event_enrichment/test_event_enrichment_main.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this parameter "mock_PoolManager" to match the regular expression ^[_a-z][a-z0-9_]*$. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_gp2gp-enhanced-mi-infrastructure&issues=AZzSZ0tvz78EidrS186O&open=AZzSZ0tvz78EidrS186O&pullRequest=89

Check failure on line 37 in lambdas/s3_event_uploader/s3_event_uploader_main.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add the 'ExpectedBucketOwner' parameter to verify S3 bucket ownership. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_gp2gp-enhanced-mi-infrastructure&issues=AZzSZ0kSz78EidrS185v&open=AZzSZ0kSz78EidrS185v&pullRequest=89

Check failure on line 55 in tasks_github_actions.sh

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_gp2gp-enhanced-mi-infrastructure&issues=AZzXJgc5wIIOqDQ9Wpln&open=AZzXJgc5wIIOqDQ9Wpln&pullRequest=89

Check failure on line 22 in tasks_github_actions.sh

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_gp2gp-enhanced-mi-infrastructure&issues=AZzXJgc5wIIOqDQ9Wplj&open=AZzXJgc5wIIOqDQ9Wplj&pullRequest=89

Check warning on line 42 in tasks_github_actions.sh

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add an explicit return statement at the end of the function. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_gp2gp-enhanced-mi-infrastructure&issues=AZzXJgc5wIIOqDQ9Wplp&open=AZzXJgc5wIIOqDQ9Wplp&pullRequest=89

Check warning on line 117 in lambdas/tests/conftest.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

AWS region should not be set with a hardcoded String 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_gp2gp-enhanced-mi-infrastructure&issues=AZzSZ0rPz78EidrS185x&open=AZzSZ0rPz78EidrS185x&pullRequest=89

Check warning on line 27 in lambdas/degrades_reporting/scripts/populate_table.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this variable; it shadows a builtin. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_gp2gp-enhanced-mi-infrastructure&issues=AZzSZ0r2z78EidrS186E&open=AZzSZ0r2z78EidrS186E&pullRequest=89

Check warning on line 63 in lambdas/degrades_reporting/scripts/generate_daily_report.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add replacement fields or use a normal string instead of an f-string. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_gp2gp-enhanced-mi-infrastructure&issues=AZzSZ0r9z78EidrS186H&open=AZzSZ0r9z78EidrS186H&pullRequest=89

Check warning on line 19 in lambdas/degrades_reporting/degrade_utils/s3_service.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename method "list_files_from_S3" to match the regular expression ^[a-z_][a-z0-9_]*$. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_gp2gp-enhanced-mi-infrastructure&issues=AZzSZ0rmz78EidrS1857&open=AZzSZ0rmz78EidrS1857&pullRequest=89

Check warning on line 106 in lambdas/bulk_ods_update/bulk_ods_update.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable "odsCode" to match the regular expression ^[_a-z][a-z0-9_]*$. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_gp2gp-enhanced-mi-infrastructure&issues=AZzSZ0u4z78EidrS186U&open=AZzSZ0u4z78EidrS186U&pullRequest=89

Check warning on line 161 in lambdas/tests/conftest.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

AWS region should not be set with a hardcoded String 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_gp2gp-enhanced-mi-infrastructure&issues=AZzSZ0rPz78EidrS185y&open=AZzSZ0rPz78EidrS185y&pullRequest=89

Check warning on line 31 in lambdas/degrades_reporting/degrade_utils/s3_service.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename method "read_file_from_S3" to match the regular expression ^[a-z_][a-z0-9_]*$. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_gp2gp-enhanced-mi-infrastructure&issues=AZzSZ0rmz78EidrS1858&open=AZzSZ0rmz78EidrS1858&pullRequest=89
View more details on SonarQubeCloud