feat: Postcode dummy codes validation#1818
Merged
Warren-Pitterson merged 27 commits intomainfrom Mar 2, 2026
Merged
Conversation
stephhou
reviewed
Jan 27, 2026
application/CohortManager/src/Functions/Shared/Common/ValidationHelper.cs
Outdated
Show resolved
Hide resolved
Warren-Pitterson
changed the title
…stcodes in static validation rules
…ub.com/NHSDigital/dtos-cohort-manager into feat/DTOSS-12099-Rule-12-Investigation
stephhou
reviewed
Feb 11, 2026
...ortManager/src/Functions/CohortDistributionServices/TransformDataService/transformRules.json
Outdated
Show resolved
Hide resolved
stephhou
reviewed
Feb 11, 2026
...ortManager/src/Functions/CohortDistributionServices/TransformDataService/transformRules.json
Outdated
Show resolved
Hide resolved
…veMultipleWhiteSpaces
…ub.com/NHSDigital/dtos-cohort-manager into feat/DTOSS-12099-Rule-12-Investigation
stephhou
reviewed
Feb 13, 2026
...ortManager/src/Functions/CohortDistributionServices/TransformDataService/transformRules.json
Outdated
Show resolved
Hide resolved
...ortManager/src/Functions/CohortDistributionServices/TransformDataService/transformRules.json
Outdated
Show resolved
Hide resolved
.../src/Functions/ScreeningValidationService/StaticValidation/Breast_Screening_staticRules.json
Show resolved
Hide resolved
...ortManager/src/Functions/CohortDistributionServices/TransformDataService/transformRules.json
Outdated
Show resolved
Hide resolved
…ub.com/NHSDigital/dtos-cohort-manager into feat/DTOSS-12099-Rule-12-Investigation
stephhou
reviewed
Feb 13, 2026
...ortManager/src/Functions/CohortDistributionServices/TransformDataService/transformRules.json
Outdated
Show resolved
Hide resolved
…ub.com/NHSDigital/dtos-cohort-manager into feat/DTOSS-12099-Rule-12-Investigation
stephhou
previously approved these changes
Feb 25, 2026
MWClayson-NHS
previously approved these changes
Feb 25, 2026
Warren-Pitterson
dismissed stale reviews from MWClayson-NHS and stephhou
via
9948a62
stephhou
previously approved these changes
Feb 26, 2026
stephhou
approved these changes
Feb 26, 2026
MWClayson-NHS
approved these changes
Mar 2, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previous Postcode Dummy code was failing validation if it didn't have a suffix, 'ZZ99' would fail but 'ZZ99 ABC' would pass, also added 2 more valid postcodes to validation,
Added Unit tests
Context
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-12099
**Test Evidence **
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.