Merged
Conversation
TheSyscall
reviewed
Jan 28, 2026
| $ad = $this->date ?? new DateTime('NOW'); | ||
| $bd = $other->date ?? new DateTime('NOW'); | ||
| $ad = $this->date ?? new DateTime('@0'); | ||
| $bd = $other->date ?? new DateTime('@0'); |
Collaborator
There was a problem hiding this comment.
There is actually no need to create DateTime objects here at all.
Simply check if one of the elements is null before trying to compare.
| protected function getContentElement(): ?BaseHtmlElement | ||
| { | ||
| $text = $this->item->description; | ||
| $text = $this->item->description ?? ''; |
Collaborator
There was a problem hiding this comment.
Description was defined as non-null in the same PR
| $d = $this->item->date; | ||
| $ts = $this->item->date !== null ? $this->item->date->getTimestamp() : 0; | ||
|
|
||
| return (new TimeAgo($ts)); |
| public ?string $title = null; | ||
| public ?string $link = null; | ||
| public ?string $description = null; | ||
| public string $description = ''; |
Collaborator
There was a problem hiding this comment.
Isn't null better than a sentinel value?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some guardrails when there are invalid items in a feed.
I switched to
new DateTime('@0')so that these elements are not shown on top.Fixed #64