(#692) Add cypress to ncids-js-testing - #694
Draft
olitharp-nci wants to merge 1 commit into
Draft
Conversation
Viewing Information |
1 similar comment
Viewing Information |
olitharp-nci
force-pushed
the
ticket/692-ncidsjs-cypress
branch
4 times, most recently
from
December 22, 2022 18:47
45f4991 to
ce60237
Compare
olitharp-nci
marked this pull request as ready for review
January 3, 2023 15:53
olitharp-nci
requested review from
KateMashkinaNIH,
arcepaul and
bryanpizzillo
January 3, 2023 16:27
KateMashkinaNIH
requested changes
Jan 4, 2023
olitharp-nci
force-pushed
the
ticket/692-ncidsjs-cypress
branch
from
January 6, 2023 18:29
ce60237 to
cf5677a
Compare
Contributor
Author
|
Thanks for those tips @KateMashkinaNIH, very helpful. I have updated. |
KateMashkinaNIH
approved these changes
Jan 9, 2023
olitharp-nci
marked this pull request as draft
September 28, 2023 21:25
|
Will remain on hold: this should be re-discussed for closing after we get Javascript working in storybook @andyvanavery31 @sarinapadilla - Link the storybook JS story here please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #692
Passing test: https://github.com/NCIOCPL/ncids/actions/runs/3752748086/jobs/6375262041
Failing test: https://github.com/NCIOCPL/ncids/actions/runs/3752865756/jobs/6375509876