FIx: update network policy for deleting groups during updates #909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s for field, netmask, and group updates
Misha-Shvets
changed the title
… and updating policies with empty groups
milov-dmitriy
requested changes
Jan 26, 2026
| dto: NetworkPolicyUpdateDTO, | ||
| ) -> NetworkPolicyDTO: | ||
| """Update network policy.""" | ||
| policy = await self._network_policy_gateway.get_with_for_update(dto.id) |
Collaborator
There was a problem hiding this comment.
может стоит внутри метода get_with_for_update сделать # NOTE: с небольшим описанием того, зачем используется .with_for_update() ?
Collaborator
Author
There was a problem hiding this comment.
расписать что делает алхимический with_for_update? ИМХО избыточно
Collaborator
Author
There was a problem hiding this comment.
нужна блокировка на запись(в целом with_for_update для этого и используют)
Collaborator
There was a problem hiding this comment.
я про то, зачем нам здесь нужна блокировка. может несколько запрсоов на изменение прийти?
…th direct check for existing policies before committing changes
milov-dmitriy
approved these changes
Jan 26, 2026
rimu-stack
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Починил логику update, раньше не рассматривался кейс, когда на обновление приходят путсые группы.
+немного отрефачил метод, а то сложно читать