Ask github if the preview deploy action has succeeded for this commit, rather than probing the preview URL - #1412
Conversation
…, rather than probing the preview URL
|
Preview removed. |
Coverage Report
File CoverageNo changed files found. |
|
Asking for readability and because I'm curious, is there a reason we can't move the wait_for_response that we currently use into the test job just behind connecting to the VPN? Both wait_for_response and the rest of the test will then have access to the VPN and work. We also trim down on one job and don't have to pass in the github token |
|
We could definitely do that. One thing I've never liked about the current approach -- making a request and checking for a 200 -- is that it's not tied to the commit. So if I open a PR and then push another commit, the test could run before the new version builds, because it'll hit a 200 right away. This guarantees it waits for the build to finish and triggers on that. |
|
That makes sense. I'm good with either approach, just was curious why you decided this way over the other |
Closes #1411
This removes the old
waitjob and does everything with the Github API (usinggh).