Repository navigation
Conversation
Author
|
The pull-request CI run expired after waiting for fork-workflow approval and contains no jobs, so its failure does not provide test results for the current head. Could a maintainer approve or retrigger a fresh CI run? I can follow up once the checks execute. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
Schema.Canonical()simplifies an invalid keyword inside a property nameda.b, it serializes the schema path as a dot-separated string and then parses that string back into parts. The property name is split intoaandb, so the simplifier misses the offending field and can reduce the entire schema to{}.For example,
{"type":"object","properties":{"a.b":{"type":"string","minLength":-1}}}canonicalized to{}on the currentmainrevision. The same schema with a property namedabretained the property and repairedminLengthto 0.Change
Keep the structured path parts on simplifiable schema errors and use those parts for the canonicalization retry. The existing public string path remains unchanged. A regression case checks that the dotted property and its repaired bound are retained.
Validation
mainand passes with this change.go test ./...with the repository's Go 1.23 toolchain.go test -race ./...with Go 1.27.1.golangci-lint run -vwith the CI-pinned v1.64.8 under Go 1.23.c-sharedlibrary and ranpython3 -m unittest discover -s python/tests -v(3 tests passed).git diff --check.