Align crossversion refusal assertions with the 0.9.0-dev naming - #387
Merged
Conversation
The 0.9.0 release bump corrected the schema-to-release map: stamps v5-v8 never shipped in a published release, so their refusals now name `0.9.0-dev` instead of the fictional 0.9.x-0.12.x lines (whose latest entry would have sent operators hunting for an omnigraph 0.13.x binary that will never exist). Four crossversion cells still asserted the old strings. The v8 cell is the only one CI runs (it builds a genuine predecessor binary from 725793a; the v5/v6/v7 cells are gated on unset env seams and skip), so main's post-merge Test Workspace went red at crossversion_upgrade.rs:891 — run 30180551717 — while every local gate stayed green, because the cell skips without OMNIGRAPH_V8_BIN. Update all four assertions to expect `0.9.0-dev`, with messages explaining why no release line exists for those stamps, and fix the two testing.md sentences that described the old guidance. Validated against the real boundary, not just compilation: built the genuine v8 binary from 725793a (`omnigraph 0.8.1 / internal-schema 8`) and ran the exact failing cell with OMNIGRAPH_V8_BIN set — green.
The corrected release map (a2215f6) records v5–v8 as unreleased 0.9.0-dev formats and v9 as the 0.9.x line, but versioning.md, writes.md, upgrade.md, and RFC-023 still described the optimistic pre-0.9.0 numbering (v6→0.10.x … v9→0.13.x) and told operators to run binaries that never existed. Rewrite the mappings and the v5→v6/v6→v7/v7→v8 rebuild walkthroughs in terms of final internal-vN source builds; RFC-023 keeps its history with a superseded note.
This was referenced Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Main's
Test Workspaceis red (run 30180551717) atcrossversion_upgrade.rs:891: the genuine-v8 cell asserts the v8 refusal contains0.12.x, but the 0.9.0 release bump corrected the schema-to-release map — stamps v5–v8 never shipped in a published release, so their refusals now name0.9.0-devinstead of fictional release lines.Four cells asserted the old strings (v5/v6/v7/v8). Only the v8 cell runs in CI (it builds a genuine predecessor binary from
725793af; the others skip without their env seams), which is why every local gate stayed green while post-merge CI went red.Backing issue / RFC
Checklist
testing.mdsentences)upgrade.mdand the release notes already document the0.9.0-devnaming)docs/dev/invariants.md— no invariant touchedValidation
CI cannot prove this pre-merge (
Test Workspaceis post-merge-only), so it was validated against the real boundary locally: built the genuine v8 binary from725793af(reportsomnigraph 0.8.1 / internal-schema 8) and ran the exact failing cell withOMNIGRAPH_V8_BINset:The v5/v6/v7 cells received the identical fix; they are env-gated and skip in CI by design.
Greptile Summary
Aligns storage-version guidance with the canonical schema-to-release mapping.
0.9.0-dev.Confidence Score: 5/5
The PR appears safe to merge.
No blocking failure remains; the revised assertions and documentation consistently match the implemented schema-to-release mapping, and the previous guidance inconsistency is resolved.
Important Files Changed
0.9.0-devlabel.Reviews (2): Last reviewed commit: "docs: retire the fictional 0.10.x–0.13.x..." | Re-trigger Greptile