New metrics are added for imbalanced data#480
Closed
mcavs wants to merge 2 commits intoModelOriented:masterfrom
mcavs:patch-1
Closed
New metrics are added for imbalanced data#480mcavs wants to merge 2 commits intoModelOriented:masterfrom mcavs:patch-1
mcavs wants to merge 2 commits intoModelOriented:masterfrom
mcavs:patch-1
Conversation
Mathews Correlation Coefficient, Balanced Accuracy, Brier Score and log-loss metrics, which are used in case of imbalanced data, are added.
hbaniecki
requested changes
Feb 21, 2022
pbiecek
requested changes
Feb 21, 2022
Member
pbiecek
left a comment
There was a problem hiding this comment.
@mcavs thank you,
for onboarding of new code please:
- add unit tests that will cover these additional functions to https://github.com/ModelOriented/DALEX/tree/master/tests
- add proper documentation (i.e. to https://modeloriented.github.io/DALEX/reference/model_performance.html)
- update https://github.com/ModelOriented/DALEX/blob/master/NEWS.md
Author
|
@pbiecek 2 added and 3 updated, but I do not know how to add unit test :/ |
Member
|
Hi @mcavs, I could try to add unit tests, but I don't see changes with respect to 2. & 3. (only the code changed looking at https://github.com/ModelOriented/DALEX/pull/480/files). |
Author
Hi @hbaniecki, I created a new pull request consists 2 and 3. You can see it on #505 |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mathews Correlation Coefficient, Balanced Accuracy, Brier Score and log-loss metrics, which are used in case of imbalanced data, are added.