Skip to content

fix: preserve selected A2A protocol on refresh #3407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TannyXie wants to merge 1 commit into
base: develop
Choose a base branch
from
+20 −63
Open

fix: preserve selected A2A protocol on refresh #3407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions backend/database/a2a_agent_db.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,13 +644,13 @@ def refresh_external_agent_cache(
agent.supported_interfaces = new_supported_interfaces
if new_protocol_type is not None:
agent.protocol_type = new_protocol_type
# Update agent_url based on the selected protocol type
interface = _find_interface_by_protocol_type(
agent.supported_interfaces,
new_protocol_type
)
if interface:
agent.agent_url = interface.get("url", agent.agent_url)

interface = _find_interface_by_protocol_type(
agent.supported_interfaces,
agent.protocol_type
)
if interface:
agent.agent_url = interface.get("url", agent.agent_url)
Comment on lines +648 to +653

agent.cached_at = now
agent.cache_expires_at = expires_at
Expand Down
69 changes: 13 additions & 56 deletions backend/services/a2a_client_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,62 +532,19 @@ async def refresh_agent_card(
new_description = card.get("description")
new_supported_interfaces = card.get("supportedInterfaces", [])

# Extract new protocol type from the card
new_protocol_type = _extract_protocol_type(new_supported_interfaces)
current_protocol_type = agent.get("protocol_type")

# Determine if we need to update agent_url and protocol_type
# Update agent_url if it changed in the remote card
update_agent_url = new_url is not None and new_url != agent_url

# Update protocol_type if it changed in the remote card
update_protocol_type = new_protocol_type != current_protocol_type

# When protocol_type changes, we need to find the corresponding interface URL
if update_protocol_type:
logger.info(
f"Protocol type changed for agent {external_agent_id}: "
f"{current_protocol_type} -> {new_protocol_type}"
)
# The database function will handle finding the correct interface URL
result = a2a_agent_db.refresh_external_agent_cache(
external_agent_id=external_agent_id,
tenant_id=tenant_id,
user_id=user_id,
new_raw_card=card,
new_agent_url=new_url if update_agent_url else None,
new_name=new_name,
new_description=new_description,
new_supported_interfaces=new_supported_interfaces,
new_protocol_type=new_protocol_type
)
elif update_agent_url:
# Only agent_url changed
logger.info(
f"Agent URL changed for agent {external_agent_id}: "
f"{agent_url} -> {new_url}"
)
result = a2a_agent_db.refresh_external_agent_cache(
external_agent_id=external_agent_id,
tenant_id=tenant_id,
user_id=user_id,
new_raw_card=card,
new_agent_url=new_url,
new_name=new_name,
new_description=new_description,
new_supported_interfaces=new_supported_interfaces
)
else:
# No changes to agent_url or protocol_type, just update metadata
result = a2a_agent_db.refresh_external_agent_cache(
external_agent_id=external_agent_id,
tenant_id=tenant_id,
user_id=user_id,
new_raw_card=card,
new_name=new_name,
new_description=new_description,
new_supported_interfaces=new_supported_interfaces
)
logger.info(
f"Refreshing agent {external_agent_id} card while preserving selected protocol: "
f"{agent.get('protocol_type')}"
)
result = a2a_agent_db.refresh_external_agent_cache(
external_agent_id=external_agent_id,
tenant_id=tenant_id,
user_id=user_id,
new_raw_card=card,
new_name=new_name,
new_description=new_description,
new_supported_interfaces=new_supported_interfaces
)
Comment on lines +535 to +547
Comment on lines +539 to +547

# Update availability
a2a_agent_db.update_agent_availability(
Expand Down