🐛 Bugfix Update pagination logic in DataMateClient and adjust related parame…#2735
Merged
🐛 Bugfix Update pagination logic in DataMateClient and adjust related parame…#2735
Conversation
…ters in search tools - Changed default page index from 0 to 1 in DataMateClient and DataMateSearchTool for consistency. - Updated KnowledgeBaseSearchTool to accept index_names as a list instead of a comma-separated string. - Modified tests to reflect changes in parameter handling and pagination behavior.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Zhi-a
changed the title
WMC001
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Update pagination logic in DataMateClient and adjust related parameters in search tools
[Bug] Datamate knowledge base search failed. #2734