Fix issue with repeat schema registration#27
Merged
Conversation
Silarn
commented
May 9, 2026
Silarn
commented
Member
- After first schema registration, storage is always set
- On subsequent registrations, the registry registration was skipped due to the storage not being null
- This should fix the storage check and allow all schemas to register properly
- After first schema registration, storage is always set - On subsequent registrations, the registry registration was skipped due to the storage not being null - This should fix the storage check and allow all schemas to register properly
Holt59
approved these changes
May 9, 2026
Holt59
left a comment
Holt59
left a comment
Member
There was a problem hiding this comment.
I don't really understand the change but this seems to have fixed the issue so.
Member
Author
|
Removing the original if statement is the important part. The rest is just preventing the code from creating a new 'storage' class when one is already instantiated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.