Conversation
Corrects documentation language related to opening_hours
richfab
added
v3.1-RC2
Contributor
|
Thank you @hbruch for raising this inconsistency in the spec. We deemed that this is an editorial change so it does not require a vote. I'll merge the change into master now (v3.1-RC2). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR corrects an inconsistency in the documentation around
opening_hours. @hbruch noted that in the documentation under Hours and Dates of Operation it says:but
system_information.opening_hoursis REQUIRED so the line quoted above should be changed from SHOULD to MUST.This is kind of a gray area but my view is that this is an editorial change to the documentation and does not require a vote. If anyone disagrees with this we can put it to a vote. That would probably also make it a breaking change which would mean it would not take effect until v4.0. If no one has an issue it will go in the next minor version.
Is this a breaking change?
Which files are affected by this change?
gbfs.md