Normalize tnumber multiplication naming from mult to mul#188
Open
estebanzimanyi wants to merge 2 commits into
Open
Normalize tnumber multiplication naming from mult to mul#188estebanzimanyi wants to merge 2 commits into
estebanzimanyi wants to merge 2 commits into
Conversation
estebanzimanyi
force-pushed
the
fix/normalize-tnumber-mult-to-mul
branch
from
cf43f57 to
97a4c41
Compare
Adds the SIZEOF_LONG_LONG emission to the rendered pg_config.h so the DuckDB-Wasm (wasm32-emscripten / ILP32) build of MEOS no longer fails the pg_bitutils integer-width check.
Renames the SQL function tnumber_mult to tnumber_mul and the Mult_* execution methods to Mul_* (bodies already call mul_int_tint / mul_tfloat_float / mul_tnumber_tnumber). The * operator overloads are unchanged.
estebanzimanyi
force-pushed
the
fix/normalize-tnumber-mult-to-mul
branch
from
97a4c41 to
e8501f7
Compare
estebanzimanyi
force-pushed
the
fix/bump-meos-pin
branch
4 times, most recently
from
fa2de57 to
17588c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the binding surface to the canonical MEOS/MobilityDB name: the SQL function tnumber_mult becomes tnumber_mul and the Mult_* execution methods become Mul_* (their bodies already call mul_int_tint / mul_tfloat_float / mul_tnumber_tnumber, so only the names change). The * operator overloads are unchanged, and the tnumber math regression tests call tnumber_mul.