feat(multi-version): foundation for DuckDB v1.4.4 LTS + v1.5.x support (selector script + Makefile target + doc)#166
Open
estebanzimanyi wants to merge 2 commits into
Conversation
This was referenced May 20, 2026
Adds the SIZEOF_LONG_LONG emission to the rendered pg_config.h so the DuckDB-Wasm (wasm32-emscripten / ILP32) build of MEOS no longer fails the pg_bitutils integer-width check.
…get + doc)
Step 1 of N — same pattern as MobilityDB-on-Postgres compiling against
PG 13-18 from one source tree, applied to DuckDB extension ABIs.
DuckDB extension ABI is version-specific: a binary built against v1.4.4
cannot load into v1.5.2 and vice versa. MobilityDuck therefore needs
to produce a separate binary per (duckdb_version, platform). The
selection is driven by the SHAs that the three submodules — duckdb,
duckdb-spatial, extension-ci-tools — point at when the build runs.
This PR adds the *foundation* that the rest of the multi-version story
builds on:
- scripts/select-duckdb-version.sh
Per-version manifest mapping a DuckDB version to matching
duckdb-spatial and extension-ci-tools refs. Switches the three
submodules in lockstep when invoked.
- Makefile
New variable DUCKDB_VERSION (default v1.4.4, the ecosystem
alignment target) and a 'make set-duckdb-version' target that
delegates to the script.
- doc/multi-duckdb-version.md
Full design: per-version manifest, build-flow diagram, how to add
a new supported version, relationship to the (future) CI matrix,
adopter install path.
- README.md
Single-sentence pointer telling adopters which versions are
supported and where the multi-version doc lives.
What this PR does NOT change:
- the committed submodule SHAs (still v1.4.4 — the default build is
identical to before)
- MainDistributionPipeline.yml (CI still builds for one version; the
matrix expansion is the next PR, stacked on this one)
- any C++ source (preprocessor conditionals for API divergences land
alongside the CI matrix once a second version's build surfaces them)
The result is a no-behaviour-change foundation: existing builds work
identically; the v1.5.x track is one 'make set-duckdb-version' away
from being buildable; the CI matrix PR turns it on in one place.
c9a4824 to
5c47f6f
Compare
estebanzimanyi
added a commit
to estebanzimanyi/MobilityDuck
that referenced
this pull request
May 30, 2026
Step 2 of N, stacks on the foundation in MobilityDB#166. Adds duckdb-build-v1-5 alongside duckdb-build-v1-4 (renamed from duckdb-latest-build, postfixed -v1-4 to disambiguate artefacts). Each row calls a different extension-ci-tools workflow tag because `uses:` in GitHub Actions cannot be a matrix expression. The v1.5.2 job is expected red until step 3 lands: - The reusable workflow's `make set_duckdb_version` handles the `duckdb/` submodule on its own, but `duckdb-spatial` and `extension-ci-tools` stay at the parent's committed SHAs (v1.4 line on `main`). No hook inside the reusable workflow lets us interleave the foundation script's swap between checkout and build. - Source-side, any DuckDB v1.5 ABI divergences (ExtensionUtil -> ExtensionLoader rename, bundled-spatial-extension surface reshuffle, etc.) will surface as compile errors during this job. Those are the signals step 3 (preprocessor conditionals) is authored against. Adding the matrix row now is the explicit visibility step: the divergences become observable in CI rather than discovered later. The deploy step for v1.5 is held until duckdb-build-v1-5 is reliably green — pushing broken binaries to the community-extension repository would be worse than no v1.5 binary. Also widens the PR-trigger branch globs to include `ci/**`, `cleanup/**`, `chore/**` (alongside the existing `feat/**` and `fix/**`) so this PR and similar follow-ups trigger CI without manual workflow_dispatch.
fa2de57 to
17588c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Step 1 of the multi-DuckDB-version effort — same pattern as MobilityDB-on-Postgres compiling against PG 13-18 from one source tree, applied to DuckDB extension ABIs.
DuckDB extension ABI is version-specific: a binary built against v1.4.4 cannot load into v1.5.2 and vice versa. MobilityDuck therefore needs to produce a separate binary per
(duckdb_version, platform). Selection is driven by the SHAs that the three submodules —duckdb,duckdb-spatial,extension-ci-tools— point at when the build runs.This PR adds the foundation that the rest of the multi-version story builds on. No behaviour change: existing builds work identically; the v1.5.x track is one
make set-duckdb-version DUCKDB_VERSION=v1.5.2away from being buildable; the CI matrix PR (step 2) turns it on across the build matrix in one place.Files
scripts/select-duckdb-version.shduckdb-spatialandextension-ci-toolsrefs. Switches the three submodules in lockstep when invoked.MakefileDUCKDB_VERSION(defaultv1.4.4, the ecosystem alignment target) and amake set-duckdb-versiontarget that delegates to the script.doc/multi-duckdb-version.mdREADME.mdSupported versions (manifest)
duckdb-spatialbranchextension-ci-toolsbranchv1.4-andiumv1.4.4v1.5-variegatav1.5-variegataUsage
What this PR explicitly does NOT change
MainDistributionPipeline.yml(CI still builds for one version; the matrix expansion is the next PR, stacked on this one).Next steps (separate PRs, stacked on this one)
MainDistributionPipeline.ymlduckdb_version: [v1.4.4, v1.5.2]matrix dimension; each row callsmake set-duckdb-versionbeforemake release.ExtensionUtil→ExtensionLoader, the bundled spatial-extension surface, etc.).test/sql/*.testfor any case where DuckDB's own behaviour changed between versions.